Fix Dashboard Suites 0408, 0409, 0410 Tests and Keywords #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: manosnoam <nmanos@redhat.com>
- The new common keyword: `Delete All ResourceType In Namespace By Name` is used within JupyterLabLauncher KW: Clean All Standalone Notebooks. - Also improve KW `Begin Web Test` with option to skip Jupyter Login in UI Signed-off-by: manosnoam <nmanos@redhat.com>
Signed-off-by: manosnoam <nmanos@redhat.com>
Signed-off-by: manosnoam <nmanos@redhat.com>
Signed-off-by: manosnoam <nmanos@redhat.com>
Signed-off-by: manosnoam <nmanos@redhat.com>
Signed-off-by: manosnoam <nmanos@redhat.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -24,18 +24,20 @@ | |||
| ... ODH dashboard, checking that the spawner is in a ready state before | |||
| ... handing control over to the test suites. | |||
| [Arguments] ${username}=${TEST_USER.USERNAME} ${password}=${TEST_USER.PASSWORD} | |||
| ... ${auth_type}=${TEST_USER.AUTH_TYPE} | |||
| ... ${auth_type}=${TEST_USER.AUTH_TYPE} ${jupyter_login}=${TRUE} | |||
Check notice
Code scanning / Robocop
There is too many arguments per continuation line ({{ arguments_count }} / {{ max_arguments_count }}) Note test
| ${GENERIC_DELETE_BTN_XP}= xpath=//*[@role="dialog"]//button[@aria-label="Delete" or .="Delete" or starts-with(., "Delete")] | ||
| ${GENERIC_STOP_BTN_XP}= xpath=//*[@role="dialog"]//button[@aria-label="Stop" or .="Stop" or starts-with(., "Stop")] | ||
| ${GENERIC_CLOSE_BTN_XP}= xpath=//*[@role="dialog"]//button[@aria-label="Close" or .="Close" or starts-with(., "Close")] | ||
| ${GENERIC_DISABLE_BTN_XP}= xpath=//*[@role="dialog"]//button[@aria-label="Disable" or .="Disable" or starts-with(., "Disable")] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
ods_ci/tests/Tests/0400__ods_dashboard/0408__ods_dashboard_settings_pod_tolerations.robot
Fixed
Show fixed
Hide fixed
...ts/Tests/0400__ods_dashboard/0410__ods_dashboard_projects/0410__ods_dashboard_projects.robot
Fixed
Show fixed
Hide fixed
...ts/Tests/0400__ods_dashboard/0410__ods_dashboard_projects/0410__ods_dashboard_projects.robot
Fixed
Show fixed
Hide fixed
...ts/Tests/0400__ods_dashboard/0410__ods_dashboard_projects/0410__ods_dashboard_projects.robot
Fixed
Show fixed
Hide fixed
Robot Results
|
Including fixes to numerous keywords within: - DataConnections.resource - Projects.resource - Storages.resource - Workbenches.resource Signed-off-by: manosnoam <nmanos@redhat.com>
|
| @@ -18,7 +18,7 @@ | |||
| ${result} = Run Keyword And Return Status Should Start With ${title} Authorize service account | |||
| RETURN ${result} | |||
|
|
|||
| Authorize jupyterhub service account | |||
| Authorize JupyterLab Service Account | |||
Check warning
Code scanning / Robocop
Missing documentation in '{{ name }}' keyword Warning test
manosnoam
requested review from
FedeAlonso,
jstourac,
jiridanek,
antowaddle,
rnetser and
bdattoma
jiridanek
approved these changes
Dec 30, 2024
manosnoam
added
verified
antowaddle
approved these changes
Dec 30, 2024
omrirh
pushed a commit
to omrirh/ods-ci
that referenced
this pull request
Dec 30, 2024
…a-services#2152) Fix Dashboard Test Suites 0408, 0409, 0410: - 0408__ods_dashboard_settings_pod_tolerations.robot - 0409__ods_dashboard_settings_accelerator_profiles.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects_permissions_mgmt.robot Including fixes to numerous keywords within: - ODHDashboard.robot - ODHDashboardSettings.resource - DataConnections.resource - Permissions.resource - Projects.resource - Storages.resource - Workbenches.resource - ODHDashboardSettingsAcceleratorProfiles.resource - AcceleratorProfiles.resource - Common.robot - Menu.robot - JupyterLabLauncher.robot Signed-off-by: manosnoam <nmanos@redhat.com>
omrirh
pushed a commit
to omrirh/ods-ci
that referenced
this pull request
Dec 30, 2024
…a-services#2152) Fix Dashboard Test Suites 0408, 0409, 0410: - 0408__ods_dashboard_settings_pod_tolerations.robot - 0409__ods_dashboard_settings_accelerator_profiles.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects_permissions_mgmt.robot Including fixes to numerous keywords within: - ODHDashboard.robot - ODHDashboardSettings.resource - DataConnections.resource - Permissions.resource - Projects.resource - Storages.resource - Workbenches.resource - ODHDashboardSettingsAcceleratorProfiles.resource - AcceleratorProfiles.resource - Common.robot - Menu.robot - JupyterLabLauncher.robot Signed-off-by: manosnoam <nmanos@redhat.com>
omrirh
pushed a commit
to omrirh/ods-ci
that referenced
this pull request
Dec 30, 2024
…a-services#2152) Fix Dashboard Test Suites 0408, 0409, 0410: - 0408__ods_dashboard_settings_pod_tolerations.robot - 0409__ods_dashboard_settings_accelerator_profiles.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects_permissions_mgmt.robot Including fixes to numerous keywords within: - ODHDashboard.robot - ODHDashboardSettings.resource - DataConnections.resource - Permissions.resource - Projects.resource - Storages.resource - Workbenches.resource - ODHDashboardSettingsAcceleratorProfiles.resource - AcceleratorProfiles.resource - Common.robot - Menu.robot - JupyterLabLauncher.robot Signed-off-by: manosnoam <nmanos@redhat.com>
lenahorsley
pushed a commit
to lenahorsley/ods-ci
that referenced
this pull request
Jan 17, 2025
…a-services#2152) Fix Dashboard Test Suites 0408, 0409, 0410: - 0408__ods_dashboard_settings_pod_tolerations.robot - 0409__ods_dashboard_settings_accelerator_profiles.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects.robot - 0410__ods_dashboard_projects/0410__ods_dashboard_projects_permissions_mgmt.robot Including fixes to numerous keywords within: - ODHDashboard.robot - ODHDashboardSettings.resource - DataConnections.resource - Permissions.resource - Projects.resource - Storages.resource - Workbenches.resource - ODHDashboardSettingsAcceleratorProfiles.resource - AcceleratorProfiles.resource - Common.robot - Menu.robot - JupyterLabLauncher.robot Signed-off-by: manosnoam <nmanos@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Dashboard Test Suites 0408, 0409, 0410:
Including fixes to numerous keywords within: