Migration of Python model kserve grpc testcase UI -> API #2155
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
|
Verified with Jenkins Build 2206 |
| @@ -19,6 +19,10 @@ | |||
|
|
|||
| *** Variables *** | |||
| ${PYTHON_MODEL_NAME}= python | |||
| ${EXPECTED_INFERENCE_GRPC_OUTPUT_PYTHON}= {"modelName":"python","modelVersion":"1","id":"1","outputs":[{"name":"OUTPUT0","datatype":"FP32","shape":["4"]},{"name":"OUTPUT1","datatype":"FP32","shape":["4"]}],"rawOutputContents":["AgAAAAAAAAAAAAAAAAAAAA==","AAQAAAAAAAAAAAAAAAAAAA=="]} | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| Set Project And Runtime runtime=${KSERVE_RUNTIME_REST_NAME} protocol=${PROTOCOL_GRPC} namespace=${test_namespace} | ||
| ... download_in_pvc=${DOWNLOAD_IN_PVC} model_name=${PYTHON_MODEL_NAME} | ||
| ... storage_size=100Mi memory_request=100Mi | ||
| ${requests}= Create Dictionary memory=1Gi |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
| Remove File ${INFERENCESERVICE_FILLED_FILEPATH} | ||
| Wait For Pods To Be Ready label_selector=serving.kserve.io/inferenceservice=${PYTHON_MODEL_NAME} | ||
| ... namespace=${test_namespace} | ||
| ${pod_name}= Get Pod Name namespace=${test_namespace} |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
|
Verified with Jenkins Build 2306 |
| @@ -196,10 +195,9 @@ Compile Inference Service YAML | |||
| ELSE | |||
| ${mode}= Get KServe Default Deployment Mode From DSC | |||
| END | |||
| Log message=Using defaultDeploymentMode set in the DSC: ${mode} | |||
| Log message=Using defaultDeploymentMode set in the DSC: ${mode}S | |||
There was a problem hiding this comment.
by mistake added S
| Log ${host} | ||
| ${inference_output}= Query Model With GRPCURL host=${host} port=443 | ||
| ... endpoint=inference.GRPCInferenceService/ModelInfer | ||
| ... json_body=@ input_filepath=${INFERENCE_GRPC_INPUT_PYTHONFILE} |
There was a problem hiding this comment.
needed @ for passing the input file for grpcurl
There was a problem hiding this comment.
i think you should be able to run this kw with json_body=${INFERENCE_GRPC_INPUT_PYTHONFILE} and adding "@" in the INFERENCE_GRPC_INPUT_PYTHONFILE, without input_filepath
There was a problem hiding this comment.
Yeah, I already tried that approach, but it didn’t work. That’s why I’m using this method. We already discussed this in another PR earlier.
There was a problem hiding this comment.
hm that's very strange..thing is that as it is this keywork call does not make much sense with "json_body=@".
I can approve it since I don't think it's hurting or causing troubles, but i'd suggest to review the code and try to find the culprit
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bdattoma, Raghul-M, tarukumar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tarukumar
merged commit 868ab73
into
red-hat-data-services:master
No description provided.