Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Monitoring Tag to Test Cases #2163

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add Monitoring Tag to Test Cases #2163

merged 1 commit into from
Jan 8, 2025

Conversation

asanzgom
Copy link
Contributor

@asanzgom asanzgom commented Jan 8, 2025

No description provided.

@asanzgom asanzgom requested review from MarianMacik and CFSNM January 8, 2025 14:18
@asanzgom asanzgom self-assigned this Jan 8, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@asanzgom asanzgom enabled auto-merge January 8, 2025 14:18
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2025
View reviewed changes
...sts/Tests/0100__platform/0102__monitor_and_manage/0101__metrics/0103__check_pager_duty.robot
@@ -33,6 +33,7 @@
... Tier1
... ODS-737
... Deployment-Cli
... Monitoring

Check warning

Code scanning / Robocop

Each next continuation line should be aligned with the previous one Warning test

Each next continuation line should be aligned with the previous one
ods_ci/tests/Tests/0100__platform/0102__monitor_and_manage/0102__alerts/0102__alerts.robot
@@ -209,7 +209,7 @@
[Tags] Sanity
... ODS-1058
... Tier1

... Monitoring

Check warning

Code scanning / Robocop

Each next continuation line should be aligned with the previous one Warning test

Each next continuation line should be aligned with the previous one
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
592 0 0 592 100

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2025
MarianMacik
MarianMacik approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe just align the new tag with former tags in two places I highlighted? But that is not a blocker, so approving.

...sts/Tests/0100__platform/0102__monitor_and_manage/0101__metrics/0103__check_pager_duty.robot
@@ -33,6 +33,7 @@ PagerDuty Dummy Secret Verification
... Tier1
... ODS-737
... Deployment-Cli
... Monitoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
... Monitoring
... Monitoring

ods_ci/tests/Tests/0100__platform/0102__monitor_and_manage/0102__alerts/0102__alerts.robot
@@ -209,7 +209,7 @@ Verify That MT-SRE Are Not Paged For Alerts In Clusters Used For Development Or
[Tags] Sanity
... ODS-1058
... Tier1

... Monitoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
... Monitoring
... Monitoring

@asanzgom asanzgom merged commit 44cfe57 into red-hat-data-services:master Jan 8, 2025
11 of 12 checks passed
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asanzgom, CFSNM, MarianMacik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asanzgom asanzgom deleted the feature/tag_monitoring_test_cases branch January 8, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CFSNM CFSNM CFSNM approved these changes

@MarianMacik MarianMacik MarianMacik approved these changes

Assignees

@MarianMacik MarianMacik

@CFSNM CFSNM

@asanzgom asanzgom

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asanzgom @MarianMacik @CFSNM