Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KFTO multi-node test names according to recent updates in orig… #2164

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Update KFTO multi-node test names according to recent updates in orig… #2164

merged 2 commits into from
Jan 27, 2025

Conversation

abhijeet-dhumal
Copy link
Contributor

Update KFTO multi-node test names according to recent updates in original test names

Related to : opendatahub-io/distributed-workloads#299

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
603 0 0 603 100

@ChughShilpa
Copy link
Contributor

What about other 2 test scenarios
TestPyTorchJobMnistMultiNodeMultiGpuWithCuda and TestPyTorchJobMnistMultiNodeMultiGpuWithROCm ?
Will you add it in another PR ?

@abhijeet-dhumal
Copy link
Contributor Author

abhijeet-dhumal commented Jan 9, 2025 •
edited
Loading

What about other 2 test scenarios TestPyTorchJobMnistMultiNodeMultiGpuWithCuda and TestPyTorchJobMnistMultiNodeMultiGpuWithROCm ? Will you add it in another PR ?

@ChughShilpa Actually the remaining MultiNode/MultiGPUs tests requires 2 cluster-nodes with minimum 2 GPUs each (GPU instance like g4dn.12xlarge - A100 GPUs), which I'm not sure whether will be available during QG tests..
Even after this pre-requisite, is it ok to add these tests here?
cc: @sutaakar

@sutaakar
Copy link
Contributor

sutaakar commented Jan 9, 2025

We can add the tests to ODS CI, just we can't run them as part of QG, only as part of our own jobs.

@ChughShilpa
Copy link
Contributor

What about other 2 test scenarios TestPyTorchJobMnistMultiNodeMultiGpuWithCuda and TestPyTorchJobMnistMultiNodeMultiGpuWithROCm ? Will you add it in another PR ?

@ChughShilpa Actually the remaining MultiNode/MultiGPUs tests requires 2 cluster-nodes with minimum 2 GPUs each (GPU instance like g4dn.12xlarge - A100 GPUs), which I'm not sure whether will be available during QG tests.. Even after this pre-requisite, is it ok to add these tests here? cc: @sutaakar

g4dn.12xlarge instance is used in qe-jenkins, and we also have Resources-2GPUS tag and can be used for this requirement, the only thing is we might need to inform the devtestops team for this

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2025
View reviewed changes
...i/tests/Tests/0600__distributed_workloads/0602__training/test-run-training-stack-tests.robot
Run Training Operator KFTO Test TestPyTorchJobMnistMultiNodeWithROCm ${ROCM_TRAINING_IMAGE}

Run Training operator KFTO_MNIST multi-node multi-gpu test with NVIDIA CUDA image
[Documentation] Run Go KFTO_MNIST multi-node multi-gpu test for Training operator using PyTorch job with NVIDIA CUDA image - It requires 2 cluster-nodes with 2 GPUs each

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (176/120)
...i/tests/Tests/0600__distributed_workloads/0602__training/test-run-training-stack-tests.robot
Run Training Operator KFTO Test TestPyTorchJobMnistMultiNodeMultiGpuWithCuda ${CUDA_TRAINING_IMAGE}

Run Training operator KFTO_MNIST multi-node multi-gpu test with AMD ROCm image
[Documentation] Run Go KFTO_MNIST multi-node multi-gpu test for Training operator using PyTorch job with AMD ROCm image - It requires 2 cluster-nodes with 2 GPUs each

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (174/120)
sutaakar
sutaakar previously approved these changes Jan 9, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2025
@abhijeet-dhumal abhijeet-dhumal force-pushed the update-kfto-mutinode-test-names branch from d8d75d4 to ffd8213 Compare January 20, 2025 11:53
@openshift-ci openshift-ci bot removed the lgtm label Jan 20, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2025
View reviewed changes
...i/tests/Tests/0600__distributed_workloads/0602__training/test-run-training-stack-tests.robot
Run Training operator KFTO_MNIST multi-node CPU test with NVIDIA CUDA image
[Documentation] Run Go KFTO_MNIST multi-node CPU test for Training operator using PyTorch job with NVIDIA CUDA image
Run Training operator KFTO_MNIST multi-node single-CPU test with NVIDIA CUDA image
[Documentation] Run Go KFTO_MNIST multi-node single-CPU test for Training operator using PyTorch job with NVIDIA CUDA image - It requires 2 cluster-nodes with at least 1 CPUs each

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (186/120)
...i/tests/Tests/0600__distributed_workloads/0602__training/test-run-training-stack-tests.robot
Run Training operator KFTO_MNIST multi-node test with NVIDIA CUDA image
[Documentation] Run Go KFTO_MNIST multi-node test for Training operator using PyTorch job with NVIDIA CUDA image
Run Training operator KFTO_MNIST multi-node multi-CPU test with NVIDIA CUDA image
[Documentation] Run Go KFTO_MNIST multi-node multi-CPU test for Training operator using PyTorch job with NVIDIA CUDA image - It requires 2 cluster-nodes with 2 CPUs each

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (176/120)
...i/tests/Tests/0600__distributed_workloads/0602__training/test-run-training-stack-tests.robot
Run Training Operator KFTO Test TestPyTorchJobMnistMultiNodeMultiCpu ${CUDA_TRAINING_IMAGE}

Run Training operator KFTO_MNIST multi-node single-GPU test with NVIDIA CUDA image
[Documentation] Run Go KFTO_MNIST multi-node single-GPU test for Training operator using PyTorch job with NVIDIA CUDA image - It requires 2 cluster-nodes with 1 GPU each

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (176/120)
...i/tests/Tests/0600__distributed_workloads/0602__training/test-run-training-stack-tests.robot
Run Training operator KFTO_MNIST multi-node test with AMD ROCm image
[Documentation] Run Go KFTO_MNIST multi-node test for Training operator using PyTorch job with AMD ROCm image
Run Training operator KFTO_MNIST multi-node single-GPU test with AMD ROCm image
[Documentation] Run Go KFTO_MNIST multi-node single-GPU test for Training operator using PyTorch job with AMD ROCm image - It requires 2 cluster-nodes with 1 GPU each

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (174/120)
@abhijeet-dhumal abhijeet-dhumal force-pushed the update-kfto-mutinode-test-names branch from ffd8213 to 2a5986d Compare January 20, 2025 12:56
sutaakar
sutaakar previously approved these changes Jan 20, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2025
jiripetrlik
jiripetrlik previously approved these changes Jan 22, 2025
View reviewed changes
@abhijeet-dhumal abhijeet-dhumal force-pushed the update-kfto-mutinode-test-names branch from 2a5986d to c098ea0 Compare January 22, 2025 08:41
@openshift-ci openshift-ci bot removed the lgtm label Jan 22, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ChughShilpa
ChughShilpa reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2025
@sutaakar
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhijeet-dhumal, ChughShilpa, jiripetrlik, sutaakar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sutaakar sutaakar merged commit fd945bf into red-hat-data-services:master Jan 27, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChughShilpa ChughShilpa ChughShilpa approved these changes

@jiripetrlik jiripetrlik jiripetrlik approved these changes

@sutaakar sutaakar sutaakar approved these changes

Assignees

@sutaakar sutaakar

@jiripetrlik jiripetrlik

@ChughShilpa ChughShilpa

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhijeet-dhumal @ChughShilpa @sutaakar @jiripetrlik