Migration of Onnx model kserve Grpc testcase UI -> API #2178
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ... AND | ||
| ... Run Keyword If "${KSERVE_MODE}"=="RawDeployment" Terminate Process triton-process kill=true | ||
|
|
||
| Test Onnx Model Grpc Inference Via API (Triton on Kserve) # robocop: off=too-long-test-case |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test
| [Tags] Tier2 RHOAIENG-16908 RunThisTest | ||
| Setup Test Variables model_name=${ONNX_MODEL_NAME} use_pvc=${FALSE} use_gpu=${FALSE} | ||
| ... kserve_mode=${KSERVE_MODE} model_path=triton/model_repository/ | ||
| Set Project And Runtime runtime=${KSERVE_RUNTIME_REST_NAME} protocol=${PROTOCOL_GRPC} namespace=${test_namespace} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| Set Project And Runtime runtime=${KSERVE_RUNTIME_REST_NAME} protocol=${PROTOCOL_GRPC} namespace=${test_namespace} | ||
| ... download_in_pvc=${DOWNLOAD_IN_PVC} model_name=${ONNX_MODEL_NAME} | ||
| ... storage_size=100Mi memory_request=100Mi | ||
| ${requests}= Create Dictionary memory=1Gi |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
..._serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve_api.robot
Fixed
Show fixed
Hide fixed
| ... namespace=${test_namespace} | ||
| ${pod_name}= Get Pod Name namespace=${test_namespace} | ||
| ... label_selector=serving.kserve.io/inferenceservice=${ONNX_MODEL_NAME} | ||
| ${valued} ${host}= Run And Return Rc And Output oc get ksvc ${ONNX_MODEL_NAME}-predictor -o jsonpath='{.status.url}' |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
|
Verified with Jenkins Build 2349 |
| [Tags] Tier2 RHOAIENG-16908 | ||
| Setup Test Variables model_name=${ONNX_MODEL_NAME} use_pvc=${FALSE} use_gpu=${FALSE} | ||
| ... kserve_mode=${KSERVE_MODE} model_path=triton/model_repository/ | ||
| Set Project And Runtime runtime=${KSERVE_RUNTIME_REST_NAME} protocol=${PROTOCOL_GRPC} namespace=${test_namespace} |
There was a problem hiding this comment.
maybe this variable should be sth like "ONNX_REST_RUNTIME_NAME" rather than "KSERVE_RUNTIME_REST_NAME"
There was a problem hiding this comment.
We are using a single template that supports all REST models, so this applies to all the remaining models as well.
There was a problem hiding this comment.
I see, then maybe "TRITON_REST_RU...."
There was a problem hiding this comment.
@bdattoma Makes sense! I will update it in the upcoming PRs.
| Remove File ${INFERENCESERVICE_FILLED_FILEPATH} | ||
| Wait For Pods To Be Ready label_selector=serving.kserve.io/inferenceservice=${ONNX_MODEL_NAME} | ||
| ... namespace=${test_namespace} | ||
| ${pod_name}= Get Pod Name namespace=${test_namespace} |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bdattoma, Raghul-M, tarukumar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
…services#2178) Co-authored-by: Tarun Kumar <takumar@redhat.com>
…services#2178) Co-authored-by: Tarun Kumar <takumar@redhat.com>
No description provided.