[2.12][fix] the Verify Notebook Has Not Restarted upgrade test #2185
Conversation
This refactores this test - the first test part is moved to "pre_upgrade" phase, because this phase is run on the pre-upgrade version with the pre-upgrade code-base (branch). This is crucial since the further phases will be run with the code-base of the upgraded product and we may hit some issues in the differences in the product otherwise. There are done other changes and fixes to the test to make it more robust including the notebook deletion in the post upgrade phase. Apart from that, to propagate the timestamp value between the phases, this introduces a configmap in the "upgrade" namespace, where we can put some context that should be passed to the followup phase. (cherry picked from commit 855d13614c867d345651ede848ba4610d5c8e96d) (cherry picked from commit 0f36dd6) (cherry picked from commit 78094ca) (cherry picked from commit 36ddf6f) (cherry picked from commit e5ec980)
|
jstourac
added
verified
jstourac
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -38,6 +41,9 @@ | |||
| ${MODEL_CREATED}= ${FALSE} | |||
| ${RUNTIME_NAME}= Model Serving Test | |||
| ${DW_PROJECT_CREATED}= False | |||
| ${CODE} while True: import time ; time.sleep(10); print ("Hello") | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent inside the variables section. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| @@ -38,6 +41,9 @@ | |||
| ${MODEL_CREATED}= ${FALSE} | |||
| ${RUNTIME_NAME}= Model Serving Test | |||
| ${DW_PROJECT_CREATED}= False | |||
| ${CODE} while True: import time ; time.sleep(10); print ("Hello") | |||
| ${UPGRADE_NS} upgrade | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent inside the variables section. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| @@ -38,6 +41,9 @@ | |||
| ${MODEL_CREATED}= ${FALSE} | |||
| ${RUNTIME_NAME}= Model Serving Test | |||
| ${DW_PROJECT_CREATED}= False | |||
| ${CODE} while True: import time ; time.sleep(10); print ("Hello") | |||
| ${UPGRADE_NS} upgrade | |||
| ${UPGRADE_CONFIG_MAP} upgrade-config-map | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent inside the variables section. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| Add And Run JupyterLab Code Cell In Active Notebook ${CODE} | ||
|
|
||
| # Get the notebook pod creation timestamp | ||
| ${notebook_pod_name}= Get User Notebook Pod Name ${TEST_USER2.USERNAME} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| @@ -35,6 +35,8 @@ | |||
| ${MODEL_CREATED}= ${FALSE} | |||
| ${RUNTIME_NAME}= Model Serving Test | |||
| ${DW_PROJECT_CREATED}= False | |||
| ${UPGRADE_NS} upgrade | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent inside the variables section. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| @@ -35,6 +35,8 @@ | |||
| ${MODEL_CREATED}= ${FALSE} | |||
| ${RUNTIME_NAME}= Model Serving Test | |||
| ${DW_PROJECT_CREATED}= False | |||
| ${UPGRADE_NS} upgrade | |||
| ${UPGRADE_CONFIG_MAP} upgrade-config-map | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent inside the variables section. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| [Tags] Upgrade | ||
| ${notebook_name}= Get User CR Notebook Name ${TEST_USER2.USERNAME} | ||
| ${notebook_pod_name}= Get User Notebook Pod Name ${TEST_USER2.USERNAME} | ||
|
|
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| ${notebook_name}= Get User CR Notebook Name ${TEST_USER2.USERNAME} | ||
| ${notebook_pod_name}= Get User Notebook Pod Name ${TEST_USER2.USERNAME} | ||
|
|
||
| # Get the running notebook creation timestamp |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
Robot Results
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiridanek, jstourac, kobihk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jstourac
merged commit 148fcd7
into
red-hat-data-services:releases/2.12.0
This refactores this test - the first test part is moved to "pre_upgrade" phase, because this phase is run on the pre-upgrade version with the pre-upgrade code-base (branch). This is crucial since the further phases will be run with the code-base of the upgraded product and we may hit some issues in the differences in the product otherwise.
There are done other changes and fixes to the test to make it more robust including the notebook deletion in the post upgrade phase.
Apart from that, to propagate the timestamp value between the phases, this introduces a configmap in the "upgrade" namespace, where we can put some context that should be passed to the followup phase.
This is a backport of #2186.
https://issues.redhat.com/browse/RHOAIENG-14840