[2.14][fix] the Verify Notebook Has Not Restarted upgrade test #2187
Conversation
This refactores this test - the first test part is moved to "pre_upgrade" phase, because this phase is run on the pre-upgrade version with the pre-upgrade code-base (branch). This is crucial since the further phases will be run with the code-base of the upgraded product and we may hit some issues in the differences in the product otherwise. There are done other changes and fixes to the test to make it more robust including the notebook deletion in the post upgrade phase. Apart from that, to propagate the timestamp value between the phases, this introduces a configmap in the "upgrade" namespace, where we can put some context that should be passed to the followup phase. (cherry picked from commit 855d13614c867d345651ede848ba4610d5c8e96d) (cherry picked from commit 0f36dd6) (cherry picked from commit 78094ca)
|
jstourac
added
verified
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -178,10 +178,9 @@ | |||
| Should Match "${ls_server}" "${EMPTY}" | |||
|
|
|||
| Get User Notebook Pod Name | |||
| [Documentation] Returns notebook pod name for given username (e.g. for user ldap-admin1 it will be jupyterhub-nb-ldap-2dadmin1) | |||
| [Documentation] Returns notebook pod name for given username (e.g. for user ldap-admin1 it will be jupyter-nb-ldap-2dadmin1-0) | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| ${MODEL_CREATED}= ${FALSE} | ||
| ${RUNTIME_NAME}= Model Serving Test | ||
| ${DW_PROJECT_CREATED}= False | ||
| ${CODE} while True: import time ; time.sleep(10); print ("Hello") |
Check warning
Code scanning / Robocop
The assignment sign is not consistent inside the variables section. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| ${return_code} ${new_timestamp} Run And Return Rc And Output oc get pod -n ${NOTEBOOKS_NAMESPACE} jupyter-nb-ldap-2dadmin2-0 --no-headers --output='custom-columns=TIMESTAMP:.metadata.creationTimestamp' #robocop:disable | ||
| Should Be Equal As Integers ${return_code} 0 | ||
| Should Be Equal ${timestamp} ${new_timestamp} msg=Running notebook pod has restarted | ||
| [Documentation] Verify Notebook pod has not restarted after the upgrade |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
Robot Results
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiridanek, jstourac, kobihk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jstourac
merged commit 5ec67f4
into
red-hat-data-services:releases/2.14.0
This refactores this test - the first test part is moved to "pre_upgrade" phase, because this phase is run on the pre-upgrade version with the pre-upgrade code-base (branch). This is crucial since the further phases will be run with the code-base of the upgraded product and we may hit some issues in the differences in the product otherwise.
There are done other changes and fixes to the test to make it more robust including the notebook deletion in the post upgrade phase.
Apart from that, to propagate the timestamp value between the phases, this introduces a configmap in the "upgrade" namespace, where we can put some context that should be passed to the followup phase.
This is a backport of #2188.
https://issues.redhat.com/browse/RHOAIENG-14840