RHOAIENG-14731 - Run ValidatingAdmissionPolicy test downstream #2192

jiripetrlik · 2025-01-27T21:23:58Z

No description provided.

openshift-ci · 2025-01-27T21:24:02Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2025-01-27T21:24:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiripetrlik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot

+    [Tags]  Tier2
+    ...     DistributedWorkloads
+    ...     WorkloadsOrchestration
+    Run DistributedWorkloads ODH Test    TestValidatingAdmissionPolicy    ${RAY_CUDA_IMAGE_3.11}    ${NOTEBOOK_IMAGE_3.11}


github-actions · 2025-01-27T21:28:54Z

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
604	0	0	604	100

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

@@ -308,3 +308,39 @@
    Container Image Url Should Contain      ${APPLICATIONS_NAMESPACE}     ${pod}      ${container}
    ...     ${registry_name}/rhoai/${expected_image}
    Log To Console    ${pod_name}'s container image is verified
+
+Enable appwrapper in Codeflare operator


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot

+    ...     DistributedWorkloads
+    ...     WorkloadsOrchestration
+    ...     MYTEST
+    [Setup]       Enable appwrapper in Codeflare operator


ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot

+    ...     WorkloadsOrchestration
+    ...     MYTEST
+    [Setup]       Enable appwrapper in Codeflare operator
+    [Teardown]    Disable appwrapper in Codeflare operator


ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot

+    ...     MYTEST
+    [Setup]       Enable appwrapper in Codeflare operator
+    [Teardown]    Disable appwrapper in Codeflare operator
+    Run DistributedWorkloads ODH Test    TestValidatingAdmissionPolicy    ${RAY_CUDA_IMAGE_3.11}    ${NOTEBOOK_IMAGE_3.11}


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    ...    shell=true
+    ...    stderr=STDOUT
+    Log To Console    ${result.stdout}
+    IF    ${result.rc} != 0


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    ...    shell=true
+    ...    stderr=STDOUT
+    Log To Console    ${result.stdout}
+    IF    ${result.rc} != 0


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    IF    ${result.rc} != 0
+        FAIL    Unable to edit codeflare-operator-config configmap
+    END
+    ${result} =    Run Process    oc -n ${APPLICATIONS_NAMESPACE} delete pod -l app.kubernetes.io/name\=codeflare-operator


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    IF    ${result.rc} != 0
+        FAIL    Unable to edit codeflare-operator-config configmap
+    END
+    ${result} =    Run Process    oc -n ${APPLICATIONS_NAMESPACE} delete pod -l app.kubernetes.io/name\=codeflare-operator


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    ...    shell=true
+    ...    stderr=STDOUT
+    Log To Console    ${result.stdout}
+    IF    ${result.rc} != 0


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    ...    shell=true
+    ...    stderr=STDOUT
+    Log To Console    ${result.stdout}
+    IF    ${result.rc} != 0


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    ...    shell=true
+    ...    stderr=STDOUT
+    Log To Console    ${result.stdout}
+    IF    ${result.rc} != 0


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    ...    shell=true
+    ...    stderr=STDOUT
+    Log To Console    ${result.stdout}
+    IF    ${result.rc} != 0


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    IF    ${result.rc} != 0
+        FAIL    Unable to reset codeflare-operator pod
+    END
+    ${result} =    Run Process    oc -n ${APPLICATIONS_NAMESPACE} wait --for\=condition\=Available deployment/codeflare-operator-manager


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+    IF    ${result.rc} != 0
+        FAIL    Unable to reset codeflare-operator pod
+    END
+    ${result} =    Run Process    oc -n ${APPLICATIONS_NAMESPACE} wait --for\=condition\=Available deployment/codeflare-operator-manager


sutaakar · 2025-02-12T10:30:59Z

ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot

+    [Tags]  Tier2
+    ...     DistributedWorkloads
+    ...     WorkloadsOrchestration
+    ...     MYTEST


Should be removed?

@sutaakar
Thank you for noticing it! Tag was removed.

sutaakar · 2025-02-12T10:35:38Z

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+
+Enable appwrapper in Codeflare operator
+    [Documentation]    Enable appwrapper in Codeflare operator
+    ${result} =    Run Process    oc -n ${APPLICATIONS_NAMESPACE} get configmap codeflare-operator-config -o yaml | sed 's/enabled: false/enabled: true/' | oc apply -n redhat-ods-applications -f -


I guess this also overrides kueueJobReconciller/waitForPodsReady , is it so?
Would it be possible to use yq to modify just the specific field?

ChristianZaccaria

Echoing what @jiripetrlik and I discussed offline:

The VAP resource's default behaviour is to reject RayClusters that don't use a LocalQueue. Hence, the resource can conflict with other tests.

As part of the teardown for that test, I recommend to disable the ValidatingAdmissionPolicyBinding resource named "kueue-validating-admission-policy-binding". This can be done as follows:

apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingAdmissionPolicyBinding
metadata:
  name: kueue-validating-admission-policy-binding
spec:
  policyName: disabled ##### SET TO DISABLED
  validationActions: [Deny]
  matchResources:
    namespaceSelector: {}

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot

+    [Tags]  Tier2
+    ...     DistributedWorkloads
+    ...     WorkloadsOrchestration
+    ...    MYTEST


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

sonarqubecloud · 2025-02-14T14:49:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+
+Enable appwrapper in Codeflare operator
+    [Documentation]    Enable appwrapper in Codeflare operator
+    ${result} =    Run Process    config_yaml\=\$(oc -n ${APPLICATIONS_NAMESPACE} get configmap codeflare-operator-config -o json | jq -r '.data."config.yaml"' | yq ".appwrapper.enabled\=true"  | sed 's/"/\\\\"/g') && oc -n ${APPLICATIONS_NAMESPACE} get configmap codeflare-operator-config -o json | jq ".data.\\"config.yaml\\"\=\\"\$config_yaml\\"" | oc apply -n ${APPLICATIONS_NAMESPACE} -f -


ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource

+
+Disable appwrapper in Codeflare operator
+    [Documentation]    Enable appwrapper in Codeflare operator
+    ${result} =    Run Process    config_yaml\=\$(oc -n ${APPLICATIONS_NAMESPACE} get configmap codeflare-operator-config -o json | jq -r '.data."config.yaml"' | yq ".appwrapper.enabled\=false"  | sed 's/"/\\\\"/g') && oc -n ${APPLICATIONS_NAMESPACE} get configmap codeflare-operator-config -o json | jq ".data.\\"config.yaml\\"\=\\"\$config_yaml\\"" | oc apply -n ${APPLICATIONS_NAMESPACE} -f -


jiripetrlik requested a review from ChristianZaccaria January 27, 2025 21:24

github-advanced-security bot found potential problems Jan 27, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from e3f21a6 to 786750e Compare February 11, 2025 22:59

github-advanced-security bot found potential problems Feb 11, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from 786750e to 118dd74 Compare February 11, 2025 23:37

github-advanced-security bot found potential problems Feb 11, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from 118dd74 to ff4d7e3 Compare February 11, 2025 23:57

github-advanced-security bot found potential problems Feb 11, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from ff4d7e3 to c83bdf4 Compare February 12, 2025 00:14

github-advanced-security bot found potential problems Feb 12, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from c83bdf4 to 3b3b44f Compare February 12, 2025 08:09

github-advanced-security bot found potential problems Feb 12, 2025

View reviewed changes

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

jiripetrlik force-pushed the RHOAIENG-14731 branch from 3b3b44f to 1982de3 Compare February 12, 2025 08:23

github-advanced-security bot found potential problems Feb 12, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from 1982de3 to 7f0516c Compare February 12, 2025 08:47

github-advanced-security bot found potential problems Feb 12, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from 7f0516c to 31f9c99 Compare February 12, 2025 08:57

github-advanced-security bot found potential problems Feb 12, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from 31f9c99 to ab75d4f Compare February 12, 2025 08:59

jiripetrlik marked this pull request as ready for review February 12, 2025 10:15

jiripetrlik requested a review from sutaakar February 12, 2025 10:16

sutaakar reviewed Feb 12, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from ab75d4f to 742bbf8 Compare February 12, 2025 10:35

sutaakar reviewed Feb 12, 2025

View reviewed changes

ChristianZaccaria requested changes Feb 12, 2025

View reviewed changes

openshift-ci bot assigned ChristianZaccaria Feb 12, 2025

jiripetrlik force-pushed the RHOAIENG-14731 branch from 742bbf8 to e402e73 Compare February 14, 2025 11:02

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

jiripetrlik force-pushed the RHOAIENG-14731 branch from e402e73 to cc8c1fb Compare February 14, 2025 11:09

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

jiripetrlik force-pushed the RHOAIENG-14731 branch from cc8c1fb to 40813fe Compare February 14, 2025 14:19

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

jiripetrlik force-pushed the RHOAIENG-14731 branch from 40813fe to d968e74 Compare February 14, 2025 14:38

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed

RHOAIENG-14731 - Run ValidatingAdmissionPolicy test downstream

4c03f4d

jiripetrlik force-pushed the RHOAIENG-14731 branch from d968e74 to 4c03f4d Compare February 14, 2025 14:48

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RHOAIENG-14731 - Run ValidatingAdmissionPolicy test downstream #2192

RHOAIENG-14731 - Run ValidatingAdmissionPolicy test downstream #2192

jiripetrlik commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

sutaakar Feb 12, 2025

jiripetrlik Feb 12, 2025

sutaakar Feb 12, 2025

ChristianZaccaria left a comment

sonarqubecloud bot commented Feb 14, 2025

RHOAIENG-14731 - Run ValidatingAdmissionPolicy test downstream #2192

Are you sure you want to change the base?

RHOAIENG-14731 - Run ValidatingAdmissionPolicy test downstream #2192

Conversation

jiripetrlik commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

Robot Results

sutaakar Feb 12, 2025

Choose a reason for hiding this comment

jiripetrlik Feb 12, 2025

Choose a reason for hiding this comment

sutaakar Feb 12, 2025

Choose a reason for hiding this comment

ChristianZaccaria left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 14, 2025

Quality Gate passed