KubeRay: Sleep for 3 seconds after disabling Kueue #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -60,6 +60,8 @@ | |||
| RHOSi Setup | |||
| # This is a temporary workaround to avoid ValidatingAdmissionPolicy check | |||
| Disable Component kueue | |||
| # ValidatingAdmissionPolicy is supported just on newer OCP, using Sleep as a workaround to make sure that ValidatingAdmissionPolicy is removed if it exists | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
abhijeet-dhumal
approved these changes
Feb 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abhijeet-dhumal, ChughShilpa, sutaakar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sutaakar
merged commit 2035664
into
red-hat-data-services:master
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidatingAdmissionPolicy is supported just on newer OCP, using Sleep as a workaround to make sure that ValidatingAdmissionPolicy is removed if it exists.
The sleep is preventing race condition which would be caused by running KubeRay tests while ValidatingAdmissionPolicy is still available.