Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File cleanup after md5sum #4339

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

chaitanyadommeti
Copy link

Description

get_md5sum_rbd_image() leaving files after md5sum. Fixed to cleanup the file after md5sum.

After fix: Execute md5sum /tmp/WkJ && rm -f /tmp/WkJ on 10.0.66.32

http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-335ZIF/Live_migration_of_qcow2_format_images_with_encryption_0.log

HaruChebrolu
HaruChebrolu previously approved these changes Dec 29, 2024
Copy link
Contributor

@HaruChebrolu HaruChebrolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Dec 29, 2024
sunilangadi2
sunilangadi2 previously approved these changes Jan 6, 2025
ceph/rbd/utils.py Outdated Show resolved Hide resolved
Signed-off-by: Chaitanya Dommeti <chaitanyadommeti@Chaitanyas-MacBook-Pro.local>
@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jan 6, 2025
Copy link
Contributor

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 7, 2025
Copy link
Contributor

@Manohar-Murthy Manohar-Murthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chaitanyadommeti, Manohar-Murthy, sunilangadi2, sunilkumarn417

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jan 8, 2025
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

New changes are detected. LGTM label has been removed.

@mergify mergify bot merged commit 3c01933 into red-hat-storage:main Jan 8, 2025
7 of 8 checks passed
@chaitanyadommeti chaitanyadommeti deleted the md5Cleanup branch January 24, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RBD Rados Bock Device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants