ErrataConnection Filter helper method - WIP #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Apr 24, 2020
stickler-ci
reviewed
Apr 24, 2020
stickler-ci
reviewed
Apr 27, 2020
ktdreyer
reviewed
Apr 27, 2020
stickler-ci
reviewed
Apr 27, 2020
yazug
force-pushed
the
filter_test
branch
2 times, most recently
from
d20904d
to
0c35a5e
Compare
ktdreyer
reviewed
Apr 27, 2020
| @@ -310,3 +310,37 @@ def get_paginated_data(self, api_url): | |||
| if page_number >= PAGE_LIMIT: | |||
| raise RuntimeError('hit pagination timeout: %d' % page_number) | |||
| return data | |||
|
|
|||
| def get_filter(self, endpoint, filter_arg, **kwargs): | |||
There was a problem hiding this comment.
I think "filter_arg" is always going to be the string "filter", right? Do we need this variable here?
There was a problem hiding this comment.
no it is not see '/errata' ... filter_args == 'errata_filter[filter_params]'
yazug@3a2bbad#diff-1a50735487483ddcd06dc38f02e580ebR379-R384
for a couple of examples, I used, extracted from various places where searching was done.
yazug
commented
Apr 28, 2020
| expose a general filter helper method to format kwargs up | ||
| as parameters for ET filter request. Then return generated | ||
| json object | ||
| """ |
There was a problem hiding this comment.
should probably include the syntax for how the url is generated
- helper method to implement general filter query pattern
- add support for release/product difference in nesting filter
parameters
- support for paginated requests
- basic unittest for filter helper based on usage
Works with the following
et.get_filter('/api/v1/releases', 'filter', is_active="true",
enabled="true", name='OpenStack 14.0.z for RHEL 7')
works with the following
et.get_filter('/errata', 'errata_filter[filter_params]',
show_type_RHBA=1, show_type_RHEA=1, show_type_RHSA=1,
show_state_NEW_FILES=1, show_state_QE=1,
show_state_REL_PREP=1,show_state_PUSH_READY=1,
open_closed_option='exclude', release=856)
Note: errata endpoint releases and products have to be special
handled to include extra [] and multiple entries if you want them
Related: red-hat-storage#132
- replaced duplicated filter query with method ErrataConnector::get_filter
- replaced duplicated filter query with method ErrataConnector::get_filter - fixup unittests to use paginated api - add fixture symlinks for external_tests api
stickler-ci
reviewed
Oct 20, 2020
yazug
changed the title
WIP usage of implemented ErrataConnector::get_filter and other helpers - get_releases_for_product - get_open_advisories_for_release - get_open_advisories_for_release_filter Note: errata endpoint releases and products have to be special handled to include extra [] and multiple entries if you want them Related: red-hat-storage#132
Extracted and extrapolated based on shale implementation
|
@yazug: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the get_filter helper method encapsulates how to query ET using standard filter pattern, where you only have to specify method call instead of string manipulation to generate the query url to send
Related: #132