Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for kubernetes-csi-addons #206

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

Bumps the github-dependencies group in /tools with 1 update: [github.com/operator-framework/operator-sdk](https://github.com/operator-framework/operator-sdk).


Updates `github.com/operator-framework/operator-sdk` from 1.36.1 to 1.37.0
- [Release notes](https://github.com/operator-framework/operator-sdk/releases)
- [Changelog](https://github.com/operator-framework/operator-sdk/blob/master/.goreleaser.yml)
- [Commits](operator-framework/operator-sdk@v1.36.1...v1.37.0)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/operator-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@df-build-team df-build-team requested a review from a team September 24, 2024 08:01
dependabot bot and others added 2 commits September 24, 2024 08:26
Bumps the golang-dependencies group with 1 update: [google.golang.org/grpc](https://github.com/grpc/grpc-go).


Updates `google.golang.org/grpc` from 1.66.2 to 1.67.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.66.2...v1.67.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
`pvc.Spec.StorageClassName` is a string pointer and can be nil or empty.
This commit adds check for both nil and empty.

Signed-off-by: Rakshith R <rar@redhat.com>
@Rakshith-R
Copy link
Member

/lgtm
/approve

Copy link

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a2e9251 into main Sep 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants