Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOWNSTREAM-ONLY] add ocs default toleration to controller podspec #211

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

leelavg
Copy link

@leelavg leelavg commented Oct 4, 2024

all components deployed as part of odf should tolerate this taint by default "node.ocs.openshift.io/storage=true:NoSchedule"

part of https://bugzilla.redhat.com/show_bug.cgi?id=2315651

@Rakshith-R
Copy link
Member

@leelavg
Copy link
Author

leelavg commented Oct 4, 2024

have we considered doing

adding downstream only change

  • if I do that now, I'm landing on this PR itself.

@Rakshith-R
Copy link
Member

Rakshith-R commented Oct 4, 2024

have we considered doing

okay thanks.

adding downstream only change

  • if I do that now, I'm landing on this PR itself.

https://github.com/red-hat-storage/kubernetes-csi-addons/blob/main/.github/PULL_REQUEST_TEMPLATE/redhat-downstream-only.md

I meant structure the commit and pr title/description accordingly similar to #30 so its easy distinguish from regular commits

all components deployed as part of odf should tolerate this taint by
default "node.ocs.openshift.io/storage=true:NoSchedule"

part of https://bugzilla.redhat.com/show_bug.cgi?id=2315651

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
@leelavg leelavg changed the title add ocs default toleration to controller podspec [DOWNSTREAM ONLY] add ocs default toleration to controller podspec Oct 4, 2024
@leelavg
Copy link
Author

leelavg commented Oct 4, 2024

its easy distinguish from regular commits

  • ack, done. Let me know if there are any mistakes. thanks!

@leelavg leelavg changed the title [DOWNSTREAM ONLY] add ocs default toleration to controller podspec [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec Oct 4, 2024
Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@leelavg
Copy link
Author

leelavg commented Oct 4, 2024

/cherrypick release-4.17

@openshift-cherrypick-robot

@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 62caf30 into red-hat-storage:main Oct 4, 2024
12 checks passed
@openshift-cherrypick-robot

@leelavg: new pull request created: #212

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants