-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOWNSTREAM-ONLY] add ocs default toleration to controller podspec #211
Conversation
@leelavg have we considered doing it through tolerations on subscription ? Refer to https://github.com/red-hat-storage/kubernetes-csi-addons/tree/main/redhat for adding downstream only change |
|
okay thanks.
I meant structure the commit and pr title/description accordingly similar to #30 so its easy distinguish from regular commits |
all components deployed as part of odf should tolerate this taint by default "node.ocs.openshift.io/storage=true:NoSchedule" part of https://bugzilla.redhat.com/show_bug.cgi?id=2315651 Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, Rakshith-R The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-4.17 |
@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
62caf30
into
red-hat-storage:main
@leelavg: new pull request created: #212 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
all components deployed as part of odf should tolerate this taint by default "node.ocs.openshift.io/storage=true:NoSchedule"
part of https://bugzilla.redhat.com/show_bug.cgi?id=2315651