Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout waiting for the machine to delete #10789

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Increase timeout waiting for the machine to delete #10789

merged 4 commits into from
Nov 14, 2024
+44 −9

Conversation

yitzhak12
Copy link
Contributor

fix #10055

@yitzhak12 yitzhak12 requested a review from a team as a code owner October 30, 2024 15:16
ocs-ci
ocs-ci reviewed Oct 30, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Nov 6, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

@yitzhak12 yitzhak12 force-pushed the increase-timeout-delete-machine branch from c9ee861 to 1b0e891 Compare November 6, 2024 15:37
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines and removed size/XS labels Nov 6, 2024
ocs-ci
ocs-ci reviewed Nov 6, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

ocs-ci
ocs-ci reviewed Nov 6, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Nov 7, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Nov 7, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@yitzhak12 yitzhak12 added the Verified Mark when PR was verified and log provided label Nov 10, 2024
AviadP
AviadP previously approved these changes Nov 10, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 10, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 10, 2024
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Nov 10, 2024
ocs-ci
ocs-ci reviewed Nov 11, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-ibm417
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Itzhak Kave added 3 commits November 11, 2024 16:40
Increase timeout waiting for the machine to delete
a6f1d61 
Signed-off-by: Itzhak Kave <ikave@ibm.com>
Get the node name from the machine and wait for node to be ready in c…
1263def 
…ase of compact mode

Signed-off-by: Itzhak Kave <ikave@ibm.com>
Add 'wait' param to the function 'delete_machine', move the machine d…
522ec79 
…eleted check to teh end of the function

Signed-off-by: Itzhak Kave <ikave@ibm.com>
@yitzhak12 yitzhak12 force-pushed the increase-timeout-delete-machine branch from 167b7c4 to 522ec79 Compare November 11, 2024 14:40
ocs-ci
ocs-ci reviewed Nov 11, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-ibm417
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Nov 12, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-ibm6-417
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Nov 12, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-ibm6-417
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

ocs-ci
ocs-ci reviewed Nov 12, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Nov 13, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-ibm6-417
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

ocs-ci
ocs-ci reviewed Nov 13, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Add option to ignore CommandFailed Exception in the function 'wait_fo…
5ce674a 
…r_delete'

Signed-off-by: Itzhak Kave <ikave@ibm.com>
ocs-ci
ocs-ci reviewed Nov 13, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation on existing cluster

Cluster Name: ikave-cmode417
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_compact_mode_3m_0w.yaml
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job state: ABORTED.

ocs-ci
ocs-ci reviewed Nov 13, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-ibm6-417
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/functional/z_cluster/nodes/test_node_replacement_proactive.py::TestNodeReplacement::test_nodereplacement_proactive
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, ebenahar, yitzhak12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 777d1c7 into red-hat-storage:master Nov 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@AviadP AviadP AviadP approved these changes

@ebenahar ebenahar ebenahar approved these changes

Assignees

@ebenahar ebenahar

@AviadP AviadP

Labels
lgtm size/M PR that changes 30-99 lines Squad/Brown Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_nodereplacement_proactive_with_io_running fails on vsphere comapct mode cluster
4 participants
@yitzhak12 @ebenahar @AviadP @ocs-ci