Skip to content

Commit

Permalink
csi: explicitly set Topology feature-gate
Browse files Browse the repository at this point in the history
issue:
external-provisioner (v5) enabled topology feature-gate by default
and the current implementation in Rook uses a conditional block to
enable the topology feature gate. This approach now does not directly
reflect the state of the `CSI_ENABLE_TOPOLOGY`.

fix:
replacing the conditional block with a direct use of the
`CSI_ENABLE_TOPOLOGY` for flag value.

Signed-off-by: Praveen M <m.praveen@ibm.com>
  • Loading branch information
iPraveenParihar committed Jul 31, 2024
1 parent d91b807 commit e30e5e8
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ spec:
- "--extra-create-metadata=true"
- "--prevent-volume-mode-conversion=true"
- "--feature-gates=HonorPVReclaimPolicy=true"
{{ if .EnableCSITopology }}
- "--feature-gates=Topology=true"
{{ end }}
- "--feature-gates=Topology={{ .EnableCSITopology }}"
{{ if .KubeApiBurst }}
- "--kube-api-burst={{ .KubeApiBurst }}"
{{ end }}
Expand Down

0 comments on commit e30e5e8

Please sign in to comment.