Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2222600: csi: update csi holder daemonset template #498

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Jul 13, 2023

Currently the holder daemonset is never updated which will leaves the images the daemonset also not updated. we should update the daemonset template but not restart the csi holder pods which causes the CSI volume access problem, set the updateStrategy to OnDelete (already set in yaml files) which allow us to update the holder daemonset but not restart/update the pods, when a pod is deleted or node is rebooted the new changes will take effect.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit 1ba3aa4)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Currently the holder daemonset is never updated
which will leaves the images the daemonset also
not updated. we should update the daemonset
template but not restart the csi holder pods
which causes the CSI volume access problem,
set the updateStrategy to OnDelete (already set in
yaml files) which allow us to update the holder
daemonset but not restart/update the pods, when a
pod is deleted or node is rebooted
the new changes will take effect.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 1ba3aa4)
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

@Madhu-1: This pull request references Bugzilla bug 2222600, which is invalid:

  • expected the bug to target the "ODF 4.13.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2222600: csi: update csi holder daemonset template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Madhu-1
Once this PR has been reviewed and has the lgtm label, please assign obnoxxx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Madhu-1
Copy link
Member Author

Madhu-1 commented Aug 24, 2023

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@Madhu-1: This pull request references Bugzilla bug 2222600, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Aug 24, 2023

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@Madhu-1: This pull request references Bugzilla bug 2222600, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "ODF 4.13.3" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai
Copy link

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@subhamkrai: This pull request references Bugzilla bug 2222600, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "ODF 4.13.3" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai
Copy link

@subhamkrai: This pull request references Bugzilla bug 2222600, which is invalid:

  • expected the bug to target the "ODF 4.13.2" release, but it targets "ODF 4.13.3" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit how to fix this issue?

I remember we did something in this file https://github.com/sunilheggodu/release/blob/59586368a53adf5c49a721114883c97bca9b4124/core-services/prow/02_config/red-hat-storage/_pluginconfig.yaml but I don't see 4.13.x entries

@agarwal-mudit
Copy link
Member

@subhamkrai This should fix it openshift/release#42649

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@agarwal-mudit: This pull request references Bugzilla bug 2222600, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@agarwal-mudit: This pull request references Bugzilla bug 2222600, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn merged commit 3a3896d into red-hat-storage:release-4.13 Aug 24, 2023
40 of 47 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@Madhu-1: All pull requests linked via external trackers have merged:

Bugzilla bug 2222600 has been moved to the MODIFIED state.

In response to this:

BUG 2222600: csi: update csi holder daemonset template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants