Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2234948: build: upgrade client-go to v0.26.4 #514

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

subhamkrai
Copy link

client-go v0.26.4 earlier than this is causing
error Segmentation violation.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

@subhamkrai: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

build: upgrade client-go tov 0.26.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai subhamkrai changed the title build: upgrade client-go tov 0.26.4 Bug 2234948: build: upgrade client-go tov 0.26.4 Aug 28, 2023
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

@subhamkrai: This pull request references Bugzilla bug 2234948, which is invalid:

  • expected the bug to target the "ODF 4.13.3" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2234948: build: upgrade client-go tov 0.26.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI is failing, you may need to run make crds, thanks for picking this up!

@travisn
Copy link

travisn commented Aug 28, 2023

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

@travisn: This pull request references Bugzilla bug 2234948, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@travisn: This pull request references Bugzilla bug 2234948, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn changed the title Bug 2234948: build: upgrade client-go tov 0.26.4 Bug 2234948: build: upgrade client-go to v0.26.4 Aug 28, 2023
client-go v0.26.4 earlier than this is causing
error `Segmentation violation`.

Signed-off-by: subhamkrai <srai@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: subhamkrai
Once this PR has been reviewed and has the lgtm label, please ask for approval from travisn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai
Copy link
Author

Looks like the CI is failing, you may need to run make crds, thanks for picking this up!

done

@BlaineEXE BlaineEXE merged commit fa9be20 into red-hat-storage:release-4.13 Aug 29, 2023
42 of 46 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@subhamkrai: All pull requests linked via external trackers have merged:

Bugzilla bug 2234948 has been moved to the MODIFIED state.

In response to this:

Bug 2234948: build: upgrade client-go to v0.26.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants