-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2235395: core: return valid CIDR ip #515
Conversation
we need to return a valid CIDR IP to get it fenced properly, the previously returned one was like `10.63.0.5:0/32` which is not a valid CIDR, removing `:0` to look like proper IP CIDR. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit eb304a5)
@subhamkrai: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@subhamkrai: This pull request references Bugzilla bug 2235395, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@Madhu-1: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Madhu-1, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
194fd1e
into
red-hat-storage:release-4.14
@subhamkrai: All pull requests linked via external trackers have merged: Bugzilla bug 2235395 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
we need to return a valid CIDR IP
to get it fenced properly, the previously
returned one was like
10.63.0.5:0/32
whichis not a valid CIDR, removing
:0
to look likeproper IP CIDR.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit eb304a5)
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-ci
on the PR.