Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2228785: object: avoid creating same bucket for two different OBC #518

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

thotz
Copy link

@thotz thotz commented Sep 6, 2023

If bucket exists for Provision(), then check whether user in the OBC and owner of bucket are same.

Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com
(cherry picked from commit b39e813)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@thotz: This pull request references Bugzilla bug 2228785, which is invalid:

  • expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2228785: object: avoid creating same bucket for two different OBC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thotz Please remove the "Bug" prefix from the commit message, the commit linter is failing. The Bug prefix only needs to be in the PR title. Thanks!

If bucket exists for Provision(), then check whether user in the OBC and
owner of bucket are same.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit b39e813)
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thotz, travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travisn travisn merged commit e185e93 into red-hat-storage:release-4.14 Sep 7, 2023
40 of 45 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

@thotz: All pull requests linked via external trackers have merged:

Bugzilla bug 2228785 has been moved to the MODIFIED state.

In response to this:

Bug 2228785: object: avoid creating same bucket for two different OBC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants