Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2234377: mds: improve the mds liveness probe calls #525

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Bug 2234377: mds: improve the mds liveness probe calls #525

merged 2 commits into from
Oct 10, 2023

Conversation

parth-gr
Copy link
Member

Description of your changes:

Instead of checking the socket files for mds daemon, check the mds daemon in fs maps

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@parth-gr
mds: improve the mds liveness probe calls
659f324 
Instead of checking the socket files for mds daemon,
check the mds daemon in fs maps

Closes: rook#12789

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 2dd9b00)
@parth-gr
ci: check mds liveness probe unit test from the CI run
601ff33 
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 3d40365)
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@parth-gr: Bugzilla bug 2234377 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

Bug 2234377: mds: improve the mds liveness probe calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link

travisn commented Oct 10, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parth-gr, travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travisn
Copy link

travisn commented Oct 10, 2023

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@travisn: Bugzilla bug 2234377 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn merged commit fe613c5 into red-hat-storage:release-4.14 Oct 10, 2023
41 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@travisn travisn

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parth-gr @travisn