Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2242374: build: update go module deps #526

Merged

Conversation

BlaineEXE
Copy link

Update go mod deps. The most interesting update is to libopenstorage/secrets which no longer uses Vault code licensed under BUSL-1.1.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Update go mod deps. The most interesting update is to
libopenstorage/secrets which no longer uses Vault code licensed under
BUSL-1.1.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

@BlaineEXE: This pull request references Bugzilla bug 2242374, which is invalid:

  • expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2242374: build: update go module deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link

travisn commented Oct 13, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BlaineEXE, travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BlaineEXE BlaineEXE merged commit 1759099 into red-hat-storage:release-4.14 Oct 13, 2023
43 of 46 checks passed
@BlaineEXE BlaineEXE deleted the bp-13032-release-414 branch October 13, 2023 16:31
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

@BlaineEXE: All pull requests linked via external trackers have merged:

Bugzilla bug 2242374 has been moved to the MODIFIED state.

In response to this:

BUG 2242374: build: update go module deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vh05 added a commit to vh05/noobaa-operator that referenced this pull request Oct 23, 2023
Port below patch
red-hat-storage/rook#526 to address licensing
issues.

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
vh05 added a commit to vh05/noobaa-operator that referenced this pull request Oct 23, 2023
Port below patch
red-hat-storage/rook#526 to address licensing
issues.

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
vh05 added a commit to vh05/noobaa-operator that referenced this pull request Oct 23, 2023
Port below patch
red-hat-storage/rook#526 to address licensing
issues.

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
vh05 added a commit to vh05/noobaa-operator that referenced this pull request Oct 23, 2023
Through this patch (libopenstorage/secrets#80), libopenstorage
repo is updated to use mpl libraries instead of busl libraries.

The updated libopenstorage code is inducted through version change
in go.mod through this patch.

We just followed the version as per red-hat-storage/rook#526 to
address mpl to busl library updation.

Also, added other module version update in this patch.

Issues:
Fixed: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
vh05 added a commit to vh05/noobaa-operator that referenced this pull request Oct 25, 2023
Through this patch (libopenstorage/secrets#80), libopenstorage
repo is updated to use mpl libraries instead of busl libraries.

The updated libopenstorage code is inducted through version change
in go.mod through this patch.

We just followed the version as per red-hat-storage/rook#526 to
address mpl to busl library updation.

Also, added other module version update in this patch.

Issues:
Fixed: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Dec 10, 2023
Through this patch (libopenstorage/secrets#80), libopenstorage
repo is updated to use mpl libraries instead of busl libraries.

The updated libopenstorage code is inducted through version change
in go.mod through this patch.

We just followed the version as per red-hat-storage/rook#526 to
address mpl to busl library updation.

Also, added other module version update in this patch.

Issues:
Fixed: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
(cherry picked from commit fa79f19)
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Dec 12, 2023
Through this patch (libopenstorage/secrets#80), libopenstorage
repo is updated to use mpl libraries instead of busl libraries.

The updated libopenstorage code is inducted through version change
in go.mod through this patch.

We just followed the version as per red-hat-storage/rook#526 to
address mpl to busl library updation.

Also, added other module version update in this patch.

Issues:
Fixed: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
(cherry picked from commit fa79f19)
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Dec 20, 2023
Through this patch (libopenstorage/secrets#80), libopenstorage
repo is updated to use mpl libraries instead of busl libraries.

The updated libopenstorage code is inducted through version change
in go.mod through this patch.

We just followed the version as per red-hat-storage/rook#526 to
address mpl to busl library updation.

Also, added other module version update in this patch.

Issues:
Fixed: https://bugzilla.redhat.com/show_bug.cgi?id=2244568
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
(cherry picked from commit fa79f19)
Signed-off-by: liranmauda <liran.mauda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants