Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2249735: fix multus net detect job all placement #537

Conversation

BlaineEXE
Copy link

Fix an issue in the network address detection job where placement was only retreived from osd and not merged with all.

Signed-off-by: Blaine Gardner blaine.gardner@ibm.com
(cherry picked from commit 0a538bf) (cherry picked from commit d829f8c)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Fix an issue in the network address detection job where placement was
only retreived from osd and not merged with all.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 0a538bf)
(cherry picked from commit d829f8c)
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 15, 2023
Copy link

openshift-ci bot commented Nov 15, 2023

@BlaineEXE: This pull request references Bugzilla bug 2249735, which is invalid:

  • expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2249735: fix multus net detect job all placement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@parth-gr
Copy link
Member

@BlaineEXE can you force push I see a lot of CI is failing

@agarwal-mudit can you do a restart?

@sunilheggodu
Copy link

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 21, 2023
Copy link

openshift-ci bot commented Nov 21, 2023

@sunilheggodu: This pull request references Bugzilla bug 2249735, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.1) matches configured target release for branch (ODF 4.14.1)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 21, 2023
Copy link

openshift-ci bot commented Nov 21, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sunilheggodu: This pull request references Bugzilla bug 2249735, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.1) matches configured target release for branch (ODF 4.14.1)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunilheggodu
Copy link

/retest

@subhamkrai
Copy link

Couple of CI issues has been fixed in rook upstream but those are no backported to downstream 4.14 so we need those also. For example rook@345f929 this.

@parth-gr
Copy link
Member

Couple of CI issues has been fixed in rook upstream but those are no backported to downstream 4.14 so we need those also. For example rook@345f929 this.

@subhamkrai I think we should include at least major one with this PR, WDYT?

github ci runner is allocating both 14 and 64 Gb disks to the setup.
Rook CI currently hard codes the lsblk with a 14G filter.
This PR updates the filter to use either 14G or 64G disks.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 345f929)
(cherry picked from commit 2088e5f)
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
objectstore deletion was failing with not found error,
Could Not get resource in k8s -- Failed to run:
kubectl [get -n object-ns CephObjectStore
other-tls-test-store -o json]
So added a check if it not found then donot check its
further condition

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 40295a9)
(cherry picked from commit 0e6604d)
@parth-gr
Copy link
Member

/approved

@parth-gr
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Nov 21, 2023

@parth-gr: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BlaineEXE
Copy link
Author

By process, I should get a LGTM review from @travisn, at which point the prow bot will merge automatically now that CI is passing.

@travisn
Copy link

travisn commented Nov 21, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
Copy link

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, parth-gr, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a34312 into red-hat-storage:release-4.14 Nov 21, 2023
46 checks passed
Copy link

openshift-ci bot commented Nov 21, 2023

@BlaineEXE: All pull requests linked via external trackers have merged:

Bugzilla bug 2249735 has been moved to the MODIFIED state.

In response to this:

Bug 2249735: fix multus net detect job all placement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BlaineEXE BlaineEXE deleted the bz-2249735-fix-multus-net-detect-job-all-placement branch November 21, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants