-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2249735: fix multus net detect job all placement #537
Bug 2249735: fix multus net detect job all placement #537
Conversation
@BlaineEXE: This pull request references Bugzilla bug 2249735, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@BlaineEXE can you force push I see a lot of CI is failing @agarwal-mudit can you do a restart? |
/bugzilla refresh |
@sunilheggodu: This pull request references Bugzilla bug 2249735, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Couple of CI issues has been fixed in rook upstream but those are no backported to downstream 4.14 so we need those also. For example rook@345f929 this. |
@subhamkrai I think we should include at least major one with this PR, WDYT? |
objectstore deletion was failing with not found error, Could Not get resource in k8s -- Failed to run: kubectl [get -n object-ns CephObjectStore other-tls-test-store -o json] So added a check if it not found then donot check its further condition Signed-off-by: parth-gr <paarora@redhat.com> (cherry picked from commit 40295a9) (cherry picked from commit 0e6604d)
/approved |
/lgtm |
@parth-gr: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
By process, I should get a LGTM review from @travisn, at which point the prow bot will merge automatically now that CI is passing. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE, parth-gr, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5a34312
into
red-hat-storage:release-4.14
@BlaineEXE: All pull requests linked via external trackers have merged: Bugzilla bug 2249735 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix an issue in the network address detection job where placement was only retreived from osd and not merged with all.
Signed-off-by: Blaine Gardner blaine.gardner@ibm.com
(cherry picked from commit 0a538bf) (cherry picked from commit d829f8c)
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-ci
on the PR.