Syncing latest changes from master for rook #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep the go dependencies minimal, add the go packages just for the pkg/apis directory. Projects that only reference the rook apis can then have a smaller footprint for Go dependencies. Signed-off-by: travisn <tnielsen@redhat.com>
Allow the flakiness threshold window to be tuned from the cli Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
…test multus: improve the multus validation test's flakiness metric
build: Add go modules for apis subdir
The merge of the go modules in the apis subdirectory missed some changes from another merge around the same time, so this will add the missing updates and fix the CI. Signed-off-by: travisn <tnielsen@redhat.com>
build: Update go modules from merge conflict
Signed-off-by: Alexander Gil <pando855@gmail.com>
add new section in dependabot configuration file to update libraries under /pkg/api folder. Signed-off-by: subhamkrai <srai@redhat.com>
bot: add directory /pkg/apis to update go pkg
Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 5.4.3 to 5.4.4. - [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md) - [Commits](wagoid/commitlint-github-action@v5.4.3...v5.4.4) --- updated-dependencies: - dependency-name: wagoid/commitlint-github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…oid/commitlint-github-action-5.4.4 build(deps): bump wagoid/commitlint-github-action from 5.4.3 to 5.4.4
docs: fix user capability name in object store user
Adding a new '-m' option for activating monitoring during cluster setup. With this option turned on, the script will handle the installation of the monitoring stack and configure the dashboard to connect to the newly installed Prometheus server automatically. Signed-off-by: Redouane Kachach <rkachach@redhat.com>
This fixes the docs deploy issues caused by the mike 2.0.0 release that removed/renamed some flags, see https://github.com/jimporter/mike/releases/tag/v2.0.0 Signed-off-by: Alexander Trost <galexrt@googlemail.com>
ci: fix mike deploy flags
test: adding support for monitoring in dev-create-cluster script
github ci runner is allocating both 14 and 64 Gb disks to the setup. Rook CI currently hard codes the lsblk with a 14G filter. This PR updates the filter to use either 14G or 64G disks. Signed-off-by: sp98 <sapillai@redhat.com>
ci: filter disks by 14 and 64 G in the CI
The new create-dev-cluster script errored out for me, not finding the deploy/examples directory. This change fixes that problem by making the path relative to the script's directory, so that it works in a rook code tree from where it is expected to be run. Signed-off-by: Michael Adam <obnox@samba.org>
…-script Improve the create-dev-cluster script
Let's use the minikube profiles feature to set up a unique profile exclusively for the Rook cluster. By doing this, we make sure that we don't run into any issues with other minikube profiles that users might already have in their local setup. Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Since nobody seems to see the instructions for opening a PR, make another attempt to clarify what someone should do when they are opening a PR. Signed-off-by: travisn <tnielsen@redhat.com>
GRPC metrics got deprecated in cephcsi 3.7.0 and the deprecated flags will get removed in the next release. This PR removes the deprecated metrics code which allow us to run with older cephcsi as well. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
build: Clarify PR template instructions
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
…ure_2 test: using minikube profiles for rook cluster creation
This reverts commit 0931259. Once we introduced encrypted OSD on partition in rook#12924. However, even though `encryptedDevice` field is `true`, an non-encrypted OSD is created. To prevent the creation of misconfigured OSD, it's better to revert rook#12924 for now. Initially, I intended to correct this problem. However, I found it will take long time because we need to change the KMS-related code, init containers of both OSD pod and OSD prepare pod. Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/helm/chart-testing-action/releases) - [Commits](helm/chart-testing-action@v2.6.0...v2.6.1) --- updated-dependencies: - dependency-name: helm/chart-testing-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.4.0 to 0.5.0. - [Commits](golang/sync@v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
csi: remove deprecated grpc metrics code
In, go 1.20 govulncheck ci is failing due to some vulnerabilities which affects windows machine and rook is not used in windows machine. The solution is to update go version to 1.21.4 Signed-off-by: subhamkrai <srai@redhat.com>
ci: add go 1.21.4 in govulncheck ci run
…r-ip-detect multus: use rook image for ip range detection
ci: fix objectsuite flakiness
Bumps the github-dependencies group with 4 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go), [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator), [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) and [github.com/spf13/cobra](https://github.com/spf13/cobra). Updates `github.com/aws/aws-sdk-go` from 1.46.6 to 1.47.9 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.46.6...v1.47.9) Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.68.0 to 0.69.1 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/prometheus-operator@v0.68.0...v0.69.1) Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.68.0 to 0.69.1 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/prometheus-operator@v0.68.0...v0.69.1) Updates `github.com/spf13/cobra` from 1.7.0 to 1.8.0 - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dcarbone/install-jq-action](https://github.com/dcarbone/install-jq-action) from 2.0.2 to 2.1.0. - [Release notes](https://github.com/dcarbone/install-jq-action/releases) - [Commits](dcarbone/install-jq-action@v2.0.2...v2.1.0) --- updated-dependencies: - dependency-name: dcarbone/install-jq-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Allow end-user to have full control on NFS-Ganesha liveness probe: - Disabled - Enabled, using user-provided definition - Enabled, using Rook's default liveness probe for Ganesha. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Use K8s LivenessProbe mechanism to check OK-status of nfs-ganesha
container. A user may define his own lineness-probe, or a default one
which expects NFS TCP-port 2049 to be active; that is, willing to accept
new connections: for Ceph>=18.2.1 issue 'rpcinfo' call on local pod;
otherwise use standard K8s TCP-socket liveness probe mechanism.
Define permissive values to liveness-probe to ensure that the NFS
service is defined in failed-state only when it has non-recoverable
error.
The current default definition of LivenessProbe is expected to guard the
nfs pod from at least the following two cases:
- Deadlocks: where an nfs-ganesha server is running, but unable serve
new connections due to internal bad-state.
- Resource exhaustion on the host node (e.g. OOM) which prevents the
server from accepting new connections and reply to NULL RPC request.
In both cases we expect K8s to reschedule the nfs pod, most likely on
different host node.
Refs rook issue rook#12719
Signed-off-by: Shachar Sharon <ssharon@redhat.com>
…dependencies-0aba6ab15d build(deps): bump the github-dependencies group with 4 updates
…rbone/install-jq-action-2.1.0 build(deps): bump dcarbone/install-jq-action from 2.0.2 to 2.1.0
This commits add check to update the deviceClass on existing pool. Signed-off-by: subhamkrai <srai@redhat.com>
pool: allow updating deviceClass on existing pool
This change to the create-dev-cluster script is intended to make the handling of invalid invocations more uniform examples are unknown options and options requiring an argument specified without one. The unification is achieved by encapsulating the corresponding code in a function. Signed-off-by: Michael Adam <obnox@samba.org>
…cluster unify treatment of invocation errors in the create-dev-cluster script
nfs: add livness-probe to nfs-ganesha container
here is the https://go.dev/play/p/SS9Q-dAiIx3 example which says the error handling was wrongly implemented Signed-off-by: parth-gr <paarora@redhat.com>
object: improve the error handling for multisite objs
Fix an issue in the network address detection job where placement was only retreived from osd and not merged with all. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
…y-all-placement multus: fix placement error for net addr detect job
Pacific is end of life and no longer necessary to support in Rook with v1.13. Signed-off-by: travisn <tnielsen@redhat.com>
core: Remove support for ceph pacific
The upgrade test should always upgrade from the previous minor release to the latest master. With 1.13 releasing soon, now we uprade from 1.12 to master, to confirm if there are any upgrade issues to 1.13. Signed-off-by: travisn <tnielsen@redhat.com>
tests: Upgrade from 1.12 to master
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from master branch