Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2255328: Update minimum ceph version required for ceph-exporter daemon #551

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

sp98
Copy link

@sp98 sp98 commented Jan 2, 2024

All regression for ceph-exporter are fixed in downstream Ceph v6.1z2, so enabling the exporter again.

(cherry picked from commit c5e35cd)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link

openshift-ci bot commented Jan 2, 2024

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

monitoring: enable exporter for downstream 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

All regression for ceph-exporter are fixed in downstream Ceph v6.1z2,
so enabling the exporter again.

(cherry picked from commit c5e35cd)

Signed-off-by: sp98 <sapillai@redhat.com>
Copy link

openshift-ci bot commented Jan 2, 2024

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

monitoring: enable exporter for downstream 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
Copy link

openshift-ci bot commented Jan 2, 2024

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

monitoring: enable exporter for downstream 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title monitoring: enable exporter for downstream 4.14 Bug 2255328: monitoring: enable exporter for downstream 4.14 Jan 2, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 2, 2024
Copy link

openshift-ci bot commented Jan 2, 2024

@sp98: This pull request references Bugzilla bug 2255328, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nagendra202

In response to this:

Bug 2255328: monitoring: enable exporter for downstream 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 2, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nagendra202.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sp98: This pull request references Bugzilla bug 2255328, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nagendra202

In response to this:

Bug 2255328: monitoring: enable exporter for downstream 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title Bug 2255328: monitoring: enable exporter for downstream 4.14 Bug 2255328: Update minimum ceph version required for ceph-exporter daemon Jan 2, 2024
Copy link

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

openshift-ci bot commented Jan 2, 2024

@avanthakkar: changing LGTM is restricted to collaborators

In response to this:

LGTM!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avanthakkar, sp98
Once this PR has been reviewed and has the lgtm label, please assign agarwal-mudit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agarwal-mudit agarwal-mudit merged commit fff70f4 into red-hat-storage:release-4.15 Jan 2, 2024
44 of 48 checks passed
Copy link

openshift-ci bot commented Jan 2, 2024

@sp98: All pull requests linked via external trackers have merged:

Bugzilla bug 2255328 has been moved to the MODIFIED state.

In response to this:

Bug 2255328: Update minimum ceph version required for ceph-exporter daemon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants