Syncing latest changes from upstream master for rook #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pg_autoscaler is always enabled by ceph and cannot be disabled. In a previous PR the pg_autoscaler config was removed from the main example. Now the remaining config for the pg_autoscaler is removed as well. Signed-off-by: travisn <tnielsen@redhat.com>
Rook has been setting the application automatically on all pools to rbd for CephBlockPools, rook-ceph-rgw for CephObjectStores, mgr on the built-in .mgr pool, and nfs on the built-in .nfs pool. The legacy pool device_health_metrics is long gone from Pacific which is no longer supported, so we can remove special handling for that pool in the upgrade guide and in the code. The application setting is now available on the pool spec although it is not expected to commonly need to override the default applications set by Rook. The application for CephFilesystem pools is now being set to cephfs, where it was previously blank. Signed-off-by: travisn <tnielsen@redhat.com>
mgr: Remove remaining pg_autoscaler examples
pool: Allow setting the application on a pool
Removed = that was preventing the import-external-cluster.sh script from importing external ceph cluster into k8s. Fixes rook#13679 Signed-off-by: Tim Olow <tim@eth0.com>
External: fix syntax error import-external-cluster.sh
Make sure the canary suites are only run from nightly CI in the rook/rook project. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
ci: stop nightly canary from running in forks
The crush rule will be updated when the failure domain changes. This update can be skipped when the expected crush rule is already configured. Otherwise, the log has a confusing message that makes it appear that the crush rule was updated when in fact it was not. Signed-off-by: travisn <tnielsen@redhat.com>
df-build-team
force-pushed
the
sync_us--master
branch
from
9047f88
to
6ce7b1f
Compare
updating go.mod and pkgs/apis/go.mod file with latest updates. Signed-off-by: subhamkrai <srai@redhat.com>
pool: Skip crush rule update when not needed
build: update go mod files
|
@df-build-team: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch