Syncing latest changes from upstream master for rook #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce CRD size by removing some descriptions for things that (a) are long, (b) are repeated, and (c) are commong kubernetes types. Remove the `Status` field from VolumeClaimTemplates (a.k.a. PVCs) in types.go to remove all unnecessary status-related fields. Use `yq` to go through generated `crds.yaml` to strip out descriptions for well-known k8s types that are long and repeated where we can't remove them from types.go. This is mostly placement descriptions and volumeSource descriptions. The overall `crds.yaml` file is reduced to less than 60% of its original size. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com> Signed-off-by: Redouane Kachach <rkachach@redhat.com> Co-authored-by: Blaine Gardner <blaine.gardner@ibm.com>
If the spec.mon.count is 5 or more, then create mon pdbs with maxUnavailable count as 2. We can afford to have more than 1 mons down while draining the nodes in this case. Signed-off-by: sp98 <sapillai@redhat.com>
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
manifest: reduce CRD size by removing some descriptions
mon: set mon pdb max unavailable as 2 in case of 5 or more mons.
earlier, we were only checking the specs of networkFence to see if unfencing is done before proceeding with deletion but we should also check the status of networkFence before proceeding with deletion. Signed-off-by: subhamkrai <srai@redhat.com>
cephFs fencing needs more testing and bug fixes to make it in production. We tried multiple fixes but still it need more work. So, removing the cephfs networkFence realted code will rever this commit when we start working on this again. Signed-off-by: subhamkrai <srai@redhat.com>
For 1.14 release supporting squid is planned as well as DNS subdomain style access to RGW buckets. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
docs: Add squid and bucket DNS subdomains to roadmap
The MDS resource requirements had an incorrect comment of the RGW component. Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
csi: disable cephFs network Fencing temporarily
mds: fix incorrect comment on crd resource requirements
df-build-team
force-pushed
the
sync_us--master
branch
from
b170ccf
to
459604a
Compare
|
@df-build-team: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch