Syncing latest changes from upstream master for rook #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users on Microsoft Azure can make use of the Azure key vault service rather than replying on any third party service for KMS. Signed-off-by: sp98 <sapillai@redhat.com>
When a private docker registry is used and an image pull secret is specified in the chart, the pods with default Service Account fail to pull the image due to authentication issues. Added rook-ceph-default service account and modify the pods specifications by adding the serviceAccountName closes: rook#12786 Closes: rook#6673 Co-authored-by: Tareq Sharafy <tareq.sha@gmail.com> Signed-off-by: parth-gr <partharora1010@gmail.com> (cherry picked from commit 737fb09) Signed-off-by: parth-gr <partharora1010@gmail.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
…aseNotes doc: PendingReleaseNotes for update netNamespaceFilePath PR
core: Set default service account on all Ceph daemons
Fixing the broken links in the docs. Signed-off-by: karthik-us <ksubrahm@redhat.com>
doc: fix broken links
This reverts commit ea700bc. Signed-off-by: karthik-us <ksubrahm@redhat.com>
Revert "doc: fix broken links"
This commit gives builders the necessary tooling to save off a docker build context for use with other tools that dont follow the same command format as $DOCKERCMD. Signed-off-by: Scott Miller <smiller1@coreweave.com>
df-build-team
force-pushed
the
sync_us--master
branch
from
7864271
to
2ae319e
Compare
Added required rbac's for required rbac for volumegroupsnapshot feature. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
update the snapshot controller to 7.0.1 and install new Volumegroup CRD's Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
volumegroupsnapshot feature will be enabled by default if the required CRD's are present if not its disabled and user will have an option to disable it if they dont require this feature. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
r is the variable name for the CSI reconciler and same is used for a local variable as well chaning it to avoid confusion and variable shadowing. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updating all the csi sidecars to the latest release. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
csi: update sidecars to latest release
build: add ability to stash docker build context
csi: support volumegroup snapshot
During cluster creation, csi config map was first filled with mon ips and without CSIDriverOptions. This commit makes sure CSIDriverOptions are added at the begining when the entry is first created. Signed-off-by: Rakshith R <rar@redhat.com>
currently the script requires to have both v2 and v1 port to enable v2 port, but that is not the necessary condition, so removing the chek, and enabling it only v2 is present to successfully configure with v2 only part-of: rook#13827 Signed-off-by: parth-gr <partharora1010@gmail.com>
Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 3 to 4. - [Release notes](https://github.com/azure/setup-helm/releases) - [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md) - [Commits](Azure/setup-helm@v3...v4) --- updated-dependencies: - dependency-name: azure/setup-helm dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
csi: update CSIDriverOption params during saving cluster config
…re/setup-helm-4 build(deps): bump azure/setup-helm from 3 to 4
The rook/ceph Dockerfile uses dnf to ensure iproute (containing the 'ip' CLI tool) is installed in the Rook image for Multus usage. This comes from the 'baseos' repo, but if any other repos are unavailable temporarily, it can cause the container build to fail. Use the '--repo baseos' flag to help prevent these kinds of failures. Additionally, this will speed up the build slightly since it does not attempt to load any non-necessary repos. This change may make the container build slightly fragile in the future if CentOS changes the name of its baseos repo, or if the Ceph image switches to a non-CentOS base image. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
external: enable the use of only v2 mon port
build: use 'baseos' as repo for iproute install
doc: add support for using azure kms
|
@df-build-team: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
travisn
approved these changes
Mar 5, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch