Syncing latest changes from master for rook #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating ubuntu image to 22.04 from 20.04 which is used in ci test Signed-off-by: subhamkrai <srai@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
docs: improve wording in BlockPoolRados Namespace CRD doc.
ci: update ubuntu image to 22.04
Update the version of Go used for govulncheck to get the latest CVE fix present in Go v1.22.3. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
ci: update go version for govulncheck
The CI step that runs markdown lint accidentally got removed as part of PR updates. Add the CI step back in. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
ci: add missing markdownlint CI step
LVM-based OSDs on PVCs are legacy and are not well tested. Therefore, we add status to the cephcluster CR that at least gives a clue that the OSDs should be replaced. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
osd: Add cephcluster status for deprecated osds to replace
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 5 to 6. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v5...v6) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go). Updates `github.com/aws/aws-sdk-go` from 1.52.2 to 1.53.0 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.52.2...v1.53.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…dependencies-58b26b4692 build(deps): bump github.com/aws/aws-sdk-go from 1.52.2 to 1.53.0 in the github-dependencies group
…angci/golangci-lint-action-6 build(deps): bump golangci/golangci-lint-action from 5 to 6
The version v2 was deprecated and was causing warnings. Signed-off-by: NymanRobin <robin.nyman@est.tech>
Afte pylint was updated to version 3.2.0 a set of new errors appeared. This makes ci passing by either fixing the problem or ignoring it in the check Signed-off-by: NymanRobin <robin.nyman@est.tech>
ci: bump github actions dependency setup-go
ci: fix pylint errors
Since pacific is no longer supported, we can remove pacific specific code. Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
since we moved to ubuntu 22.04, ci push image build is failing due wrong parameter `--platforms linux/amd64 linux/arm64,` it should be instead `--platforms linux/amd64, linux/arm64`. Signed-off-by: subhamkrai <srai@redhat.com>
…image ci: push image ci failing in ubuntu 22.04
…code core: remove pacific specific code
after cross-storageclass clone/restore, now we can clone across different storageclass. this commit updates the documentation indicating the same. Signed-off-by: yati1998 <ypadia@redhat.com>
The last pr missed removing the extra comma after the platform so, instead of ` linux/amd64,linux/arm64,` it should be ` linux/amd64,linux/arm64`. Signed-off-by: subhamkrai <srai@redhat.com>
ci: remove extra comma from platforms
doc: Update documentation for volume clone
…-master Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
add generated csv changes Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
Syncing latest changes from upstream master for rook
update rook csv version to 4.17 Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
core: remove owner refs in resource cleanup jobs
csv: Update csv version
docs: document how to have StorageClass consume Rados Namespace
currently node predicate watches for resourceVersion and heartbeat changes, which are not critical things. So with the PR we will add a early-exit condition for the predicate as an optimization and to ignore considering for a reconcile of cephcluster if updates are not crucial closes: rook#14070 Signed-off-by: parth-gr <partharora1010@gmail.com>
core: do not watch resourceversion and heartbeat node updates
Syncing latest changes from upstream master for rook
When IPv6-only network mode is enabled and when mons are configured to listen only on msgrV2 port, Rook has to add the port to the mon --public-bind-addr in order to force mons to stop listening on the msgrV1 port. This can cause problems for IPv6 clusters where adding ':<port>' to the end of an IP addr looks like a valid IPv6 address. In IPv6 mode, Rook needs to set this to '[<ip>]:<port>' with the brackets to be a non-ambiguous IPv6 address. In IPv4 mode, Rook needs to keep its existing behavior. IPv4 mode should also continue to be the defualt assumption if the network config isn't specified. If 'dualStack: true' is specified, Rook is informed that the environment is dual stack, but Rook doesn't know which IP family to expect from the pod IP. In this scenario, it is safest for Rook not to apply the port, since assuming either IPv4 or IPv6 format could be incorrect. In this scenario, mons may still listen on msgrV1 ports, but this is preferable to an environment where mons perpetually crash. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
Signed-off-by: NymanRobin <robin.nyman@est.tech>
docs: fix broken link to network config
Syncing latest changes from upstream master for rook
mon: fix bind addr when IPv6 and msgr2 are enabled
fixing 'secert' to `secret` and adding workds like `NotIn, addin` to skip work list. Signed-off-by: subhamkrai <srai@redhat.com>
This PR adds a `settings` option in the `Module` struct which can help users to futher customize the `balancer` module with a differet mode. Signed-off-by: sp98 <sapillai@redhat.com>
ci: fix codespell ci by skipping some words
This reduces the safe-to-remove retry interval from 1m to 15s. Closes rook#14247 Signed-off-by: Brian Dowling <bjd-dev@simplicity.net>
Syncing latest changes from upstream master for rook
Add a note to remove LimitNOFILE setting in containerd service configuration. This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks), various timeouts, and mons failing/timing out. Upstream containerd already removed the setting. NixOS hasn't incorporated the change. This note can be removed once NixOS/nixpkgs#313507 makes it to a stable release. Signed-off-by: Onur Cakmak <occ@occ.me>
Currently we allow upgrade of other OSDs while migration of OSD, due to change in backing store, is pending. This will not work if the updated OSD ceph version does not support the currently applied backing store. So rook will skip any OSD upgrade if the OSD migration is pending. Signed-off-by: sp98 <sapillai@redhat.com>
…eout osd: reduce safe-to-destroy retry timeout to 15s
docs: Add a note for NixOS and containerd
osd: skip upgrade if migration is pending
mgr: setting balancer mode from cluster spec.
…-master Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
add generated csv changes Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from master branch