Syncing latest changes from master for rook #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pick up the latest ceph prometheus rules from the ceph repo found at https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/prometheus_alerts.yml. The updates include new rules for monitoring of ceph as well as adjustments related to the Rook ceph deployment. List of main adjustments: - Alerts related to cephadm are excluded - The PrometheusJobMissing alert is adjusted for the rook-ceph-mgr job, and the PrometheusJobExporterMissing alert is added Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Bumps the github-dependencies group with 2 updates: [github.com/IBM/keyprotect-go-client](https://github.com/IBM/keyprotect-go-client) and [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go). Updates `github.com/IBM/keyprotect-go-client` from 0.14.0 to 0.14.1 - [Release notes](https://github.com/IBM/keyprotect-go-client/releases) - [Changelog](https://github.com/IBM/keyprotect-go-client/blob/master/CHANGELOG.md) - [Commits](IBM/keyprotect-go-client@v0.14.0...v0.14.1) Updates `github.com/aws/aws-sdk-go` from 1.53.14 to 1.53.19 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.53.14...v1.53.19) --- updated-dependencies: - dependency-name: github.com/IBM/keyprotect-go-client dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…dependencies-977e0afb3f build(deps): bump the github-dependencies group with 2 updates
monitoring: update to the latest ceph prometheus rules
Storage classes were missing the possilbilty to attach custom labels and annotations. This change brings it on par with VolumeSnapshotClass objects. Signed-off-by: Peter Dahlberg <catdog2@tuxzone.org>
…rageclass helm: allow custom labels and annotations for storage classes
this will be disabled by default but in scenarios where the user want to update failureDomain, DeviceClass etc, this option can be enabled, to be noted this can lead to lot of data rebalancing and remapping. Use with caution Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
Signed-off-by: Deepika Upadhyay <deepikaupadhyay01@gmail.com>
this lead to creation of 2 crush rules because of difference in
deviceClass names:
eg:
creating a new crush rule for changed deviceClass
("default~hdd"-->"hdd") on crush rule "test-crush-bug-az-ab-4"
Signed-off-by: Deepika Upadhyay <deepikaupadhyay01@gmail.com>
pool: get the exact deviceClass name instead of crushroot+deviceClass
The snyk security check started failing with a warning about the package being outdated: github.com/libopenstorage/secrets/azure which depends on github.com/Azure/azure-sdk-for-go/sdk/azidentity. These and related packages are now updated. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
with recent discussion we come to conclusion nfs can be suported easily in the external cluster so adding the design that we discussed closes: rook#13277 Signed-off-by: parth-gr <partharora1010@gmail.com>
doc: add recommendation for nfs in external cluster
core: Update go modules for snyk security check
The endpoint property honorLabels: true should be set so that different rgw instances can show separate prometheus values instead of being aggregated. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
monitoring: Set honor labels on the service monitor
Prometheus found duplicate series for the match group `pool_id` and `instance` when evaluating the CephPoolGrowthWarning alert expression. This alert has an evaluation interval of 2 days and did not consider the changing POD names during the Rook migration process. This commit adds the `pod` label to the set of considered labels. Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Bumps the github-dependencies group with 3 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go), [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) and [github.com/spf13/cobra](https://github.com/spf13/cobra). Updates `github.com/aws/aws-sdk-go` from 1.53.19 to 1.54.2 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.53.19...v1.54.2) Updates `github.com/ceph/go-ceph` from 0.27.0 to 0.28.0 - [Release notes](https://github.com/ceph/go-ceph/releases) - [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md) - [Commits](ceph/go-ceph@v0.27.0...v0.28.0) Updates `github.com/spf13/cobra` from 1.8.0 to 1.8.1 - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.0...v1.8.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/ceph/go-ceph dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…dependencies-fd2d6e934b build(deps): bump the github-dependencies group with 3 updates
enableCrushUpdates option: rook operator would not be able to update crush rules by default if not set
…g_expr monitoring: fix CephPoolGrowthWarning expression
…-master Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
add generated csv changes Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
Syncing latest changes from upstream master for rook
subhamkrai
approved these changes
Jun 20, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from master branch