Bug 2293881: osd: revert limit storageClassDeviceSets to 63 chars #669
Conversation
openshift-ci
bot
added
bugzilla/severity-low
|
@subhamkrai: This pull request references Bugzilla bug 2269099, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@subhamkrai: This pull request references Bugzilla bug 2269099, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (vkathole@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
openshift-ci
bot
added
lgtm
added one more comment to make most CI happy @agarwal-mudit cc @sp98 |
|
/lgtm |
|
@subhamkrai general question: I can see we added validation in CephCluster CR, but downstream this is controlled by StorageCluster CR. Shouldn't we do the same for StorageCluster CRD as well ?? |
stroageCluster Name will come to rook only and in rook it was throwing error, so we have added here |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Multus requires that the 'ip' tool be installed in the Rook image. Today, it is present in the upstream Ceph base image that is used, but that is expected to change in the future. The Ceph project intends to switch to CentOS 9 minimal images, and the 'ip' tool will likely be removed from the base image at that point. However, Rook CI has occasionally had issues with the current 'dnf install' command when CentOS repos go down, or when there is otherwise some problem. Because the package is already installed today, there is no need to hamstring Rook builds when CentOS is having problems. But we do want to make sure that Rook builds don't silently succeed in the eventual future when 'ip' tool is removed from the Ceph image. For now, replace the 'dnf install' with a check to verify that 'ip' tool is installed, and add a shorter form of this note as a comment above it to help Rook maintainers know how to resolve future 'ip' tool removal. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com> (cherry picked from commit c4e99c1)
This reverts commit ef4592a. Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
force-pushed
the
update-ds-limit-40
branch
from
2935145
to
3b11bbf
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
subhamkrai
changed the title
openshift-ci
bot
added
bugzilla/severity-unspecified
|
@subhamkrai: This pull request references Bugzilla bug 2293881, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
subhamkrai
changed the title
openshift-ci
bot
added
bugzilla/valid-bug
|
@subhamkrai: This pull request references Bugzilla bug 2293881, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@subhamkrai: This pull request references Bugzilla bug 2293881, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: agarwal-mudit, sp98, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@subhamkrai: All pull requests linked via external trackers have merged: Bugzilla bug 2293881 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This commits reverts changes done to limit the storageClassDeviceSets Name for 4.16 due to upgrade issues.
There is another commit added in this pr
build: remove iproute build dependency on centos reposo that most of the build and e2e CI is greenChecklist: