Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream master for rook #670

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream master branch

subhamkrai and others added 2 commits June 20, 2024 10:51
initially, we have the limit of 40 char set on
storageclassdeviceset.Name but seems like that is not enough and
upgrade clusters can face issue with this. So, increasing the limit to
50.

Signed-off-by: subhamkrai <srai@redhat.com>
…t-limit

core: increase storage deviceset name limit to 50
@df-build-team df-build-team requested a review from a team June 20, 2024 08:08
This reverts commit 1dcc99e.

Signed-off-by: subhamkrai <srai@redhat.com>
This reverts commit 6f5cc9b.

Signed-off-by: subhamkrai <srai@redhat.com>
core: revert increase storage deviceset name limit to 50
Ceph Jenkins added 2 commits June 23, 2024 04:04
…-master

Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
add generated csv changes

Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: df-build-team, subhamkrai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai subhamkrai merged commit d36871c into master Jun 24, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants