forked from rook/rook
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from upstream master for rook #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initially, we have the limit of 40 char set on storageclassdeviceset.Name but seems like that is not enough and upgrade clusters can face issue with this. So, increasing the limit to 50. Signed-off-by: subhamkrai <srai@redhat.com>
…t-limit core: increase storage deviceset name limit to 50
df-build-team
force-pushed
the
sync_us--master
branch
from
June 21, 2024 08:05
284528b
to
239658b
Compare
core: revert increase storage deviceset name limit to 50
df-build-team
force-pushed
the
sync_us--master
branch
from
June 22, 2024 08:06
239658b
to
1b7ab7f
Compare
…-master Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
add generated csv changes Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
df-build-team
force-pushed
the
sync_us--master
branch
from
June 23, 2024 08:06
1b7ab7f
to
eafb58a
Compare
subhamkrai
approved these changes
Jun 24, 2024
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch