Syncing latest changes from upstream master for rook #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While adding a new encryption key to slot 1 if there exists a key in slot 1 which is not equal to the one we want to update it with, we kill the slot and then add the new key to it. While killing the slot, the existing code uses the new key, which is not valid in such cases. This patch modifies the code to use the key in slot 0 (the one that we know works) to kill the slot. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
osd: Use old passphrase to kill the LUKS slot
df-build-team
force-pushed
the
sync_us--master
branch
from
eafb58a
to
3a72a2a
Compare
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go). Updates `github.com/aws/aws-sdk-go` from 1.54.2 to 1.54.6 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.54.2...v1.54.6) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
subhamkrai
approved these changes
Jun 24, 2024
…dependencies-9b2da29897 build(deps): bump github.com/aws/aws-sdk-go from 1.54.2 to 1.54.6 in the github-dependencies group
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch