Syncing latest changes from upstream master for rook #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip creating networkFence when 'ROOK_CSI_DISABLE_DRIVER' is set to 'false'. Signed-off-by: subhamkrai <srai@redhat.com>
Block devices can move between reboots. In corner cases, an OSDs block device might move to a lower-indexed device while the previous device does not exist. For example, an OSD on /dev/sde might move to /dev/sdd on reboot if the original /dev/sdd died. There would be no /dev/sde after that. Users report that NVMe drives commonly change names, even when there are no disk failures. For these cases, ensure the activate script properly handles cases where the previous disk is not present on the node and where the OSD is still available on a different disk. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
user can look back to there configurations by looking at the configmap created with command line arguments This will be useful for them during upgrades when they need to re run the python script with the same flags Signed-off-by: parth-gr <partharora1010@gmail.com>
…e-change osd: fix activate failure when block device moves
external: create a configmap for the command line args
…abled csi: skip creating networkFence when csi disabled
…-master Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
add generated csv changes Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch