forked from rook/rook
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from upstream master for rook #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the flexibility to configure kube apiserver qps as per the user requirement and also keeps the existing values as the default one. Signed-off-by: yite.gu <yitegu0@gmail.com>
…rable csi: make kube apiserver qps configurable
Update the vhost-style S3 bucket access design doc to reflect recent user feedback and configuration issues. The primary goal is to add a field to disambiguate for users and Rook which endpoint should be used for CephObjectStoreUsers, OBCs, and COSI buckets. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
This reverts commit bd4250f. Signed-off-by: subhamkrai <srai@redhat.com>
the templateParam need to be updated with the right values before we are rendering the template. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
this commits adds desgin doc for integrating the new csi operator with rook. Signed-off-by: subhamkrai <srai@redhat.com>
csi: fix template render in logRotation
currently, it was blocking both the mds ip instead its should block ip of of mds which is in the same node which is down. Signed-off-by: subhamkrai <srai@redhat.com>
docs: design for csi operator integration with rook
doc: update vhost-style S3 bucket design
mds: block of active mds ip only
subhamkrai
approved these changes
Jul 19, 2024
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch