Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2297285: exporter: bind to all interfaces if IPv6 is enabled #711

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

subhamkrai
Copy link

Previously ceph-exporter would only bind to IPv4 interfaces. Now if the CephCluster is configured with dualStack: true and/or ipFamily: IPv6 an additional flag (--addrs ::) will be added to the ceph-exporter container to make it listen both IPv6 and IPv4 interfaces.

Signed-off-by: Matthew Penner me@matthewp.io
(cherry picked from commit d09a43d) (cherry picked from commit 9744c97)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Previously ceph-exporter would only bind to IPv4 interfaces. Now if the
CephCluster is configured with `dualStack: true` and/or `ipFamily: IPv6`
an additional flag (`--addrs ::`) will be added to the ceph-exporter
container to make it listen both IPv6 and IPv4 interfaces.

Signed-off-by: Matthew Penner <me@matthewp.io>
(cherry picked from commit d09a43d)
(cherry picked from commit 9744c97)
Copy link

openshift-ci bot commented Aug 27, 2024

@subhamkrai: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

exporter: bind to all interfaces if IPv6 is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@subhamkrai subhamkrai changed the title exporter: bind to all interfaces if IPv6 is enabled Bug 2297285: exporter: bind to all interfaces if IPv6 is enabled Aug 27, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 27, 2024
Copy link

openshift-ci bot commented Aug 27, 2024

@subhamkrai: This pull request references Bugzilla bug 2297285, which is invalid:

  • expected the bug to target the "ODF 4.14.10" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2297285: exporter: bind to all interfaces if IPv6 is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@subhamkrai
Copy link
Author

/bugzilla refresh

Copy link

openshift-ci bot commented Aug 27, 2024

@subhamkrai: This pull request references Bugzilla bug 2297285, which is invalid:

  • expected the bug to target the "ODF 4.14.10" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@subhamkrai
Copy link
Author

/bugzilla refresh

Copy link

openshift-ci bot commented Aug 27, 2024

@subhamkrai: This pull request references Bugzilla bug 2297285, which is invalid:

  • expected the bug to target the "ODF 4.14.10" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@subhamkrai
Copy link
Author

/bugzilla refresh

Copy link

openshift-ci bot commented Sep 6, 2024

@subhamkrai: This pull request references Bugzilla bug 2297285, which is invalid:

  • expected the bug to target the "ODF 4.14.10" release, but it targets "ODF 4.14.11" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sunilheggodu
Copy link

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 6, 2024
Copy link

openshift-ci bot commented Sep 6, 2024

@sunilheggodu: This pull request references Bugzilla bug 2297285, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.11) matches configured target release for branch (ODF 4.14.11)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 6, 2024
Copy link

openshift-ci bot commented Sep 6, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sunilheggodu: This pull request references Bugzilla bug 2297285, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.11) matches configured target release for branch (ODF 4.14.11)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
Copy link

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp98, subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp98 sp98 merged commit d4ed445 into red-hat-storage:release-4.14 Sep 6, 2024
41 of 46 checks passed
Copy link

openshift-ci bot commented Sep 6, 2024

@subhamkrai: All pull requests linked via external trackers have merged:

Bugzilla bug 2297285 has been moved to the MODIFIED state.

In response to this:

Bug 2297285: exporter: bind to all interfaces if IPv6 is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants