forked from rook/rook
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from upstream master for rook #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing the clean-up of raw device OSDs, it was not taking metadata and wal devices into account. This commit discover them via the output of `ceph-volume raw list`, which is returning `device_db` and/or `device_wal` if they are present. After discovering the metadata and wal device it also clean them and close the encrypted device if any. Signed-off-by: Mathias Chapelain <mathias.chapelain@proton.ch>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@39cd149...f677139) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.6 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@834a144...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.5 to 3.26.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@2c779ab...4dd1613) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the github-dependencies group with 1 update: [github.com/csi-addons/kubernetes-csi-addons](https://github.com/csi-addons/kubernetes-csi-addons). Updates `github.com/csi-addons/kubernetes-csi-addons` from 0.9.0 to 0.9.1 - [Release notes](https://github.com/csi-addons/kubernetes-csi-addons/releases) - [Commits](csi-addons/kubernetes-csi-addons@v0.9.0...v0.9.1) --- updated-dependencies: - dependency-name: github.com/csi-addons/kubernetes-csi-addons dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…dependencies-2c13738831 build(deps): bump github.com/csi-addons/kubernetes-csi-addons from 0.9.0 to 0.9.1 in the github-dependencies group
…hub/codeql-action-3.26.6 build(deps): bump github/codeql-action from 3.26.5 to 3.26.6
…ions/upload-artifact-4.4.0 build(deps): bump actions/upload-artifact from 4.3.6 to 4.4.0
updating csi-addons to latest v0.9.1 release. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
…ions/setup-python-5.2.0 build(deps): bump actions/setup-python from 5.1.1 to 5.2.0
csi: update csi-addons to v0.9.1
osd: discover metadata and wal devices for raw device cleanup
When removing a mon from quorum, there is a race condition that can result in mon quorum going being lost at least temporarily. The mon pod was being deleted first, and then the mon removed from quorum. If any other mon went down between the time the pod of the bad mon was deleted and when the mon was removed from quorum, there may not be sufficient quorum to complete the action of removing the mon from quorum and the operator would be stuck. For example, there could be 4 mons temporarily due to timing of upgrading K8s nodes where mons may be taken down for some number of minutes. Say a new mon is started while the down mon also comes back up. Now the operator sees it can remove the 4th mon from quorum, so it starts to remove it. Now say another mon goes down on another node that is being updated or otherwise drained. Since the 4th mon pod was deleted and another mon is down, there are only two mons remaining in quorum, but 3 mons are required in quorum when there are 4 mons. Therefore, the quorum is stuck until the third mon comes back up. The solution is to first remove the extra mon from quorum before taking down the mon pod. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
This new setting is of Boolean type and defaults to "false". When set to "true", it changes the behavior of the rook operator to nable host network on all pods created by the cephcluster controller new method to check the setting: opcontroller.EnForceHostNetwork() Signed-off-by: Michael Adam <obnox@samba.org>
introduce a way to enforce host network on all pods
mon: Remove extra mon from quorum before taking down pod
df-build-team
force-pushed
the
sync_us--master
branch
from
September 6, 2024 08:10
8ca102a
to
772a4fa
Compare
subhamkrai
approved these changes
Sep 6, 2024
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch