Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2310385: external: mds caps to healthchecker/cephfs users #733

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

subhamkrai
Copy link

for cephfs fencing in external mode, we run command ceph tell mds *** which requires user user to include cap mds allow * in permission. So, we need to add this in healthchercker and cephfs provisioner user

Signed-off-by: subhamkrai srai@redhat.com
(cherry picked from commit 32c5d99) (cherry picked from commit 690a4a6)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

for cephfs fencing in external mode, we run command `ceph tell mds ***`
which requires user user to include cap mds allow * in permission. So,
we need to add this in healthchercker and cephfs provisioner user

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 32c5d99)
(cherry picked from commit 690a4a6)
Copy link

openshift-ci bot commented Sep 20, 2024

@subhamkrai: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

external: mds caps to healthchecker/cephfs users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@subhamkrai subhamkrai changed the title external: mds caps to healthchecker/cephfs users Bug 2310385: external: mds caps to healthchecker/cephfs users Sep 20, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 20, 2024
Copy link

openshift-ci bot commented Sep 20, 2024

@subhamkrai: This pull request references Bugzilla bug 2310385, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jopinto@redhat.com), skipping review request.

In response to this:

Bug 2310385: external: mds caps to healthchecker/cephfs users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

this commit upgrade the minikube, k8s, crictl versions
in CI and also fix permission error in the github runner.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit f647444)
(cherry picked from commit 3b91880)
this commit is added to include the csv changes that
are comming by changing the python script. In upstream,
we don't have csv that's why we need to include it here
as a separate commit.

Signed-off-by: subhamkrai <srai@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@subhamkrai
Copy link
Author

/approve

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sp98, subhamkrai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai subhamkrai merged commit a4d65a5 into red-hat-storage:release-4.17 Sep 20, 2024
50 of 51 checks passed
Copy link

openshift-ci bot commented Sep 20, 2024

@subhamkrai: All pull requests linked via external trackers have merged:

Bugzilla bug 2310385 has been moved to the MODIFIED state.

In response to this:

Bug 2310385: external: mds caps to healthchecker/cephfs users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants