-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates providers #300
Open
Aboisier
wants to merge
12
commits into
main
Choose a base branch
from
templates-providers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Templates providers #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a perdu la belle arborescence qu'on avait ici avant, dans les templates: Avant on avait les built-in dans un folder et les autres templates dans un autre folder. Ils étaient aussi classés par language. Je sais pas si c'est quelque chose qu'on veut garder. C'etait un truc du genre:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "source" concept for jobs, job templates and subscriptions. The code is not optimal as it contains duplication. Might refine later, but I wanted to get this up quick to fix licensing problems.
Highlights:
templateOrdering
renaming — renamed it tocategory
To-do:
Resilience — the system is currently not resilient to an import failure. For instanceIf a certain source is down, all jobs/subs/templates will be deleted (oops)If a specific item can't be imported, the whole server crashesCustomJobMetadataV1 — Can this be deleted?GitSource duplication — The code pulling the repo is duplicated. Maybe refactor?Tests — The tests are absolutely exploding