-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates providers #300
Templates providers #300
Conversation
On a perdu la belle arborescence qu'on avait ici avant, dans les templates: Avant on avait les built-in dans un folder et les autres templates dans un autre folder. Ils étaient aussi classés par language. Je sais pas si c'est quelque chose qu'on veut garder. C'etait un truc du genre:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai review vite fait pour trouver les endroits où j'aurais pu oublier de considérer la branch
et j'en ai trouvé plusieurs. À date c'est très fort
This PR adds the "source" concept for jobs, job templates and subscriptions. The code is not optimal as it contains duplication. Might refine later, but I wanted to get this up quick to fix licensing problems.
Highlights:
templateOrdering
renaming — renamed it tocategory
To-do:
Resilience — the system is currently not resilient to an import failure. For instanceIf a certain source is down, all jobs/subs/templates will be deleted (oops)If a specific item can't be imported, the whole server crashesCustomJobMetadataV1 — Can this be deleted?GitSource duplication — The code pulling the repo is duplicated. Maybe refactor?Tests — The tests are absolutely exploding