Giving the job container from the jobs manager #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s manager for more flexibility
lm-sec
commented
Nov 18, 2024
Comment on lines
+26
to
+41
| const modelUpdate: KafkaJobModelUpdate = { | ||
| _id: update._id, | ||
| name: update.name, | ||
| code: update.code, | ||
| container: update.container, | ||
| jobPodConfigId: update.jobPodConfigId, | ||
| language: update.language, | ||
| parameters: update.parameters, | ||
| type: update.type, | ||
| builtIn: update.builtIn, | ||
| category: update.category, | ||
| findingHandler: update.findingHandler, | ||
| findingHandlerEnabled: update.findingHandlerEnabled, | ||
| findingHandlerLanguage: update.findingHandlerLanguage, | ||
| image: update.container.image, | ||
| }; |
There was a problem hiding this comment.
Si t'as une suggestion pour faire ca mieux, je suis ouvert, j'ai perdu pas mal de temps là-dessus, for some reason faire
const modelUpdate: KafkaJobModelUpdate = {
...update,
image: update.container.image,
};ne fonctionnait pas.
|
Les tests ne pourront pas passer tant que la PR pour les jobs dans l'autre repo ne sera pas appliquée |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving the job container from the job manager is a step forward in having custom containers. It makes it much easier to support new containers.
Can be selected in the front-end: