bugfix/#18863/Remove default license of GeoIP and add a Setting to manualy install the license #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Label Bot has predicted the following:
|
…stalling the manager
manegron
added a commit
that referenced
this pull request
Oct 19, 2024
* bugfix/#18863/Remove default license of GeoIP and add a Setting to manualy install the license (#7) * Redmine Bugfix #18863: Get geoip license from settings * Bump and changelog * Redmine Bugfix #18863: Added license key check when executing when installing the manager * Redmine Bugfix #18863: Added condition to geoipupdate when installing * Use license_key instead of node * reverse changelog update and metadata version * Add user_id --------- Co-authored-by: Miguel Negron <manegron@redborder.com> * Bump version --------- Co-authored-by: ptorresred <ptorres@redborder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue in RedMine
Remove default license of GeoIP and add a Setting to manualy install the license: https://redmine.redborder.lan/issues/18863
Description / Motivation
Fixed (#18863): Geoip was using hardcoded license. We needed a license field in settings that was used by geoip when executed
Detail
Got rid of hardcoded license key. Now the key will be get from General Settings.
Also added the next line to "resources/providers/config.rb" file:
not_if { node['redborder']['geoip_key'].nil? || node['redborder']['geoip_key'].empty? }This line will make sure that geoipupdate is not executed when installing the manager if the license does not exist or if it has not been written in the generated settings yet.