Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/17260 wrong configuration monitor services #12

Merged

Conversation

nilsver
Copy link
Contributor

@nilsver nilsver commented May 15, 2024

Previously, calculating the memory_per_service was allowed to check on any service with a non-false value to be considered active. This included services defined with empty hashes.
Now we will check if the service is explicitly set to true, before calculating the memory.

@the-label-bot the-label-bot bot added the size/S size/S label May 15, 2024
Copy link

the-label-bot bot commented May 15, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind bug 0.826 ✔️
Size M 0.932 ✔️

@the-label-bot the-label-bot bot added the kind/bug kind/bug label May 15, 2024
@the-label-bot the-label-bot bot added size/M size/M and removed size/S size/S labels May 29, 2024
@JPeraltaNic JPeraltaNic self-requested a review June 3, 2024 10:23
@JPeraltaNic JPeraltaNic self-assigned this Jun 3, 2024
@JPeraltaNic JPeraltaNic merged commit 50f88d2 into development Jun 3, 2024
0 of 2 checks passed
@JPeraltaNic JPeraltaNic deleted the bugfix/17260_wrong_configuration_monitor_services branch June 3, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug size/M size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants