Fixed security issue where the user could access unathorized files by…

… inputting a relative path into the API

resources/src/server/rest.py

@@ -105,8 +105,11 @@ def calculate():
             else:
                 try:
                     decoded_model = base64.b64decode(model).decode('utf-8')
-                    model_path = os.path.join(self.ai_path, f"{decoded_model}.keras")
-                    if not os.path.isfile(model_path):
+                    model_path = os.path.normpath(os.path.join(self.ai_path, f"{decoded_model}.keras"))
+                    if not model_path.startswith(os.path.normpath(self.ai_path)):
+                        logger.logger.error(f"Attempted unauthorized file access: {decoded_model}")
+                        model = 'default'
+                    elif not os.path.isfile(model_path):
                         logger.logger.error(f"Model {decoded_model} does not exist")
                         model = 'default'
                     else:

resources/tests/test_rest.py

@@ -68,6 +68,18 @@ def test_calculate_endpoint_invalid_model(self, mock_isfile, mock_execute_model,
             self.assertEqual(response.status_code, 200)
             self.assertEqual(response.get_json(), self.output_data)
 
+    @patch('druid.client.DruidClient.execute_query')
+    @patch('ai.shallow_outliers.ShallowOutliers.execute_prediction_model')
+    @patch('os.path.isfile')
+    def test_calculate_endpoint_unathorized_model_access(self, mock_isfile, mock_execute_model, mock_query):
+        mock_execute_model.return_value = self.output_data
+        mock_query.return_value = {}
+        mock_isfile.return_value = False
+        data = {'model':'Li90ZXN0', 'query':'eyJhc2RmIjoiYXNkZiJ9'}
+        with self.api_server.app.test_client().post('/api/v1/outliers', data=data) as response:
+            self.assertEqual(response.status_code, 200)
+            self.assertEqual(response.get_json(), self.output_data)
+
     @patch('druid.client.DruidClient.execute_query')
     @patch('ai.shallow_outliers.ShallowOutliers.execute_prediction_model')
     @patch('os.path.isfile')