Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR-39: Add default model logic to the api #42

Merged
merged 6 commits into from
Jan 10, 2024
Merged

PR-39: Add default model logic to the api #42

merged 6 commits into from
Jan 10, 2024

Conversation

PRodriguezFlores
Copy link
Contributor

@PRodriguezFlores PRodriguezFlores commented Jan 9, 2024 •
edited
Loading

  • Added the default model to the API.
  • Introduced new API tests.
  • Refactored variable names to adhere to snake_case naming convention.
  • Updated the scikit-learn version requirement to address security vulnerabilities.

PRodriguezFlores and others added 5 commits November 17, 2023 11:02
@PRodriguezFlores
Added support for default outliers detection and some initial testing…
1e26e81 
… for rest.py
@PRodriguezFlores
Updated scikit-learn module for security issues
ad2bf67
Improved error handling logic and introduced a new test to check if t…
0c6578d 
…he API is able to call the deep learning model
Improved logic and error handling when selecting a model in the api a…
f98b25e 
…nd improved its tests, solved an issue where the outliers model failed to load some data when reading a json and renamed some variables not in camel_case
Fixed mistake when calculating outlier threshold
7c57547
@auto-assign auto-assign bot requested review from malvads and manegron January 9, 2024 12:52
@the-label-bot the-label-bot bot added kind/feature kind/feature size/L size/L labels Jan 9, 2024
@the-label-bot The Label Bot
Copy link

the-label-bot bot commented Jan 9, 2024 •
edited
Loading

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.893 ✔️
Size L 0.973 ✔️

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7367688) 70.81% compared to head (224a938) 77.67%.

Files Patch % Lines
resources/src/ai/outliers.py 88.23% 4 Missing ⚠️
resources/src/server/rest.py 91.30% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   70.81%   77.67%   +6.86%     
==========================================
  Files          13       13              
  Lines         627      663      +36     
==========================================
+ Hits          444      515      +71     
+ Misses        183      148      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

malvads
malvads approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@malvads malvads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@malvads malvads merged commit 5cf7968 into master Jan 10, 2024
13 checks passed
@malvads malvads deleted the add_default_model_logic branch January 10, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malvads malvads malvads approved these changes

@manegron manegron Awaiting requested review from manegron

Assignees

@manegron manegron

@malvads malvads

Labels
kind/feature kind/feature size/L size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PRodriguezFlores @malvads @manegron