Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR-40: Add dynamic filters #44

Merged
merged 18 commits into from
Jan 29, 2024
Merged

PR-40: Add dynamic filters #44

merged 18 commits into from
Jan 29, 2024

Conversation

PRodriguezFlores
Copy link
Contributor

  • Model now supports all valid Druid filters, expanding beyond previous sensor-only filtering.
  • Each model accompanied by three files: {model_name}.keras (TensorFlow model), {model_name}.ini (configuration), and {model_name}_filter.json (filter for prediction and training).
  • Streamlined imports using project's base directory for all inner submodules.
  • Significantly improved test coverage across the repository.

@auto-assign auto-assign bot requested review from malvads and manegron January 29, 2024 08:57
@the-label-bot the-label-bot bot added the kind/feature kind/feature label Jan 29, 2024
@the-label-bot the-label-bot bot added the size/XL size/XL label Jan 29, 2024
Copy link

the-label-bot bot commented Jan 29, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.873 ✔️
Size XL 0.822 ✔️

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (3c5e463) 77.67% compared to head (d6361bb) 82.58%.

Files Patch % Lines
resources/src/redborder/async_jobs/train_job.py 40.47% 25 Missing ⚠️
resources/src/__main__.py 0.00% 6 Missing ⚠️
resources/src/redborder/rq.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   77.67%   82.58%   +4.90%     
==========================================
  Files          13       13              
  Lines         663      735      +72     
==========================================
+ Hits          515      607      +92     
+ Misses        148      128      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PRodriguezFlores PRodriguezFlores changed the title PR-40: Add dynamic filters PR-40: Add dynamic filters Jan 29, 2024
@malvads malvads merged commit da31ecc into master Jan 29, 2024
14 checks passed
@malvads malvads deleted the add_dynamic_filters branch January 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature size/XL size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants