Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR-56: Add direct data execution #60

Merged
merged 12 commits into from
Apr 24, 2024
Merged

PR-56: Add direct data execution #60

merged 12 commits into from
Apr 24, 2024

Conversation

PRodriguezFlores
Copy link
Contributor

  • Added feature where the models can be executed directly with druid data, not only with druid queries.
  • Provided test for new functionality.
  • Refactored API logic.
  • Added example script of how to use the service.
  • Updated README to include the example.
  • Simplified loss function used by the model and updated the model to be compatible with said loss function.
  • Updated the project to python 3.9.
  • Updated requirements.txt.

Pablo Rodríguez Flores and others added 12 commits April 9, 2024 13:08
Added example to the README
Improved README example.
Updated tests.yml to python 3.9, the same as RedBorder NG is using currently.
Updated security.yml to python 3.9, the same as the current RedBorder NG version.
Updated lint.yml to python 3.9, the same as the current RedBorder NG version.
@auto-assign auto-assign bot requested review from malvads and manegron April 10, 2024 13:02
@the-label-bot the-label-bot bot added kind/feature kind/feature size/XL size/XL labels Apr 10, 2024
Copy link

the-label-bot bot commented Apr 10, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.829 ✔️
Kind XL 0.832 ✔️

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.17%. Comparing base (517564a) to head (72806ad).
Report is 2 commits behind head on master.

Files Patch % Lines
resources/src/server/rest.py 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   82.95%   83.17%   +0.22%     
==========================================
  Files          13       13              
  Lines         745      755      +10     
==========================================
+ Hits          618      628      +10     
  Misses        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PRodriguezFlores PRodriguezFlores changed the title PR-35: Add direct data execution PR-56: Add direct data execution Apr 10, 2024
Copy link
Member

@malvads malvads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@malvads malvads merged commit 3e4f15a into master Apr 24, 2024
17 checks passed
@PRodriguezFlores PRodriguezFlores deleted the add_direct_data_execution branch June 4, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants