Skip to content

PR-62: Fix issue shallow outliers fails to initialize #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

PRodriguezFlores
Copy link
Contributor

  • Fixed an issue where the shallow outliers wouldn't initialize properly in the API REST because it was not converting some values from the config to float.
  • Included a test so this doesn't happen again.

@auto-assign auto-assign bot requested review from malvads and manegron June 3, 2024 09:22
@the-label-bot the-label-bot bot added kind/bug kind/bug size/S size/S labels Jun 3, 2024
Copy link

the-label-bot bot commented Jun 3, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind bug 0.992 ✔️
Size S 0.968 ✔️

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.35%. Comparing base (8bed888) to head (458f6ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files          13       13           
  Lines         769      769           
=======================================
  Hits          641      641           
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@malvads malvads merged commit 039738b into master Jun 7, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug size/S size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants