-
Notifications
You must be signed in to change notification settings - Fork 145
Test/benchmarking #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Test/benchmarking #632
Conversation
| "pytest-benchmark==3.2.3", | ||
| "py", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are test dependencies, so they should go in requirements-dev.txt.
rbs-jacob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny changes in addition to Wyatt's suggestion. Otherwise, this is a great improvement to the pipeline! Hopefully there are no performance regressions, but at least we'll be able to see them if they're there.
| --volume /ofrak_pyghidra_benchmarks:/ofrak_pyghidra/.benchmarks \ | ||
| --entrypoint bash \ | ||
| redballoonsecurity/ofrak/ghidra:latest \ | ||
| -c "python -m ofrak_ghidra.server start \ | ||
| && ofrak license --community --i-agree \ | ||
| && make test" | ||
| && make test \ | ||
| && make -C /ofrak_pyghidra benchmark" | ||
| cat /ofrak_pyghidra_benchmarks/benchmark.json > $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| --volume /ofrak_pyghidra_benchmarks:/ofrak_pyghidra/.benchmarks \ | |
| --entrypoint bash \ | |
| redballoonsecurity/ofrak/ghidra:latest \ | |
| -c "python -m ofrak_ghidra.server start \ | |
| && ofrak license --community --i-agree \ | |
| && make test" | |
| && make test \ | |
| && make -C /ofrak_pyghidra benchmark" | |
| cat /ofrak_pyghidra_benchmarks/benchmark.json > $GITHUB_STEP_SUMMARY | |
| --volume "$(pwd)/benchmarks":/ofrak_pyghidra/.benchmarks \ | |
| --entrypoint bash \ | |
| redballoonsecurity/ofrak/ghidra:latest \ | |
| -c "python -m ofrak_ghidra.server start \ | |
| && ofrak license --community --i-agree \ | |
| && make test \ | |
| && make -C /ofrak_pyghidra benchmark" | |
| cat benchmarks/benchmark.json >> $GITHUB_STEP_SUMMARY |
GitHub won't allow me to make a proper suggestion on this code snippet, but perhaps something like the above.
One sentence summary of this PR (This should go in the CHANGELOG!)
Adds benchmarking to the Github Actions workflow.
Link to Related Issue(s)
N/A
Please describe the changes in your request.
Anyone you think should look at this, specifically?
@whyitfor