Skip to content

Add a visitor to assist in migrating form config from v4 to v5 #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: feature/ng19-forms
Choose a base branch
from
Draft

Add a visitor to assist in migrating form config from v4 to v5 #3505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9cd4782
initial work on form config migration using the visitor pattern
cofiem Nov 14, 2025
1ab2fa7
implemented populating component, model, layout blocks
cofiem Nov 17, 2025
d0545f5
Merge branch 'refs/heads/feature/ng19-forms' into feature/ng19-forms-…
cofiem Nov 17, 2025
7bb418b
follow nested v4 field definition fields
cofiem Nov 18, 2025
e92c766
migrate some component-specific properties
cofiem Nov 18, 2025
9e8e268
migrate some component-specific properties
cofiem Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/sails-ng-common/src/config/component/tab.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {
FieldComponentConfigKind, FieldComponentDefinitionKind, FieldLayoutConfigKind, FieldLayoutDefinitionKind,
FormComponentDefinitionKind
FormComponentDefinitionKind, KeyValueStringProperty
} from "../shared.outline";
import {
ButtonSectionAriaOrientationOptionsType,
Expand Down Expand Up @@ -44,9 +44,10 @@ export class TabFieldComponentDefinition extends FieldComponentDefinition implem


export class TabFieldLayoutConfig extends FieldLayoutConfig implements TabFieldLayoutConfigOutline {
buttonSectionCssClass?: string;
tabPaneCssClass?: string;
tabPaneActiveCssClass?: string;
hostCssClasses?: KeyValueStringProperty = 'd-flex align-items-start';
buttonSectionCssClass?: string = 'nav flex-column nav-pills me-5';
tabPaneCssClass?: string = 'tab-pane fade';
tabPaneActiveCssClass?: string = 'active show';
buttonSectionAriaOrientation?: ButtonSectionAriaOrientationOptionsType = 'vertical';

constructor() {
Expand Down
8 changes: 7 additions & 1 deletion packages/sails-ng-common/src/config/visitor/base.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {get as _get} from "lodash";
import {FormConfigFrame, FormConfigOutline} from "../form-config.outline";
import {FormConfigOutline} from "../form-config.outline";
import {CanVisit, FormConfigVisitorOutline} from "./base.outline";
import {
SimpleInputFieldComponentDefinitionOutline,
Expand Down Expand Up @@ -430,6 +430,12 @@ export class PopulateProperties {
}

const propValue = [target, ...sources].findLast(val => val?.[name] !== undefined)?.[name];

// for debugging:
// if (name === 'options') {
// console.log(`Get property ${JSON.stringify(name)} from sources ${JSON.stringify(sources)} for target ${JSON.stringify(target)} propValue ${JSON.stringify(propValue)}.`);
// }

if (propValue !== undefined) {
target[name] = propValue;
}
Expand Down
Loading