Fix: Implement pagination for article file list retrieval in Figshare Service #3526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y and set user to root for mocha service
…mint/redbox-portal into bugfix/figshare-pagination-issue
…e 'master' branch
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3526 +/- ##
==========================================
- Coverage 48.48% 48.46% -0.02%
==========================================
Files 184 184
Lines 10891 10897 +6
Branches 1657 1660 +3
==========================================
+ Hits 5280 5281 +1
- Misses 5380 5385 +5
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewbrazzatti
changed the title
cofiem
requested changes
Nov 24, 2025
Contributor
cofiem
left a comment
cofiem
left a comment
There was a problem hiding this comment.
Looks good! A few changes and questions.
…s for edge scenarios
…shareService tests
cofiem
reviewed
Nov 24, 2025
| axiosResponses = []; | ||
| service = new FigshareService(); | ||
| // Set required properties that are private in TS but accessible at runtime | ||
| (service as any).baseURL = 'https://api.figshare.test'; |
Contributor
There was a problem hiding this comment.
.localhost is good - please update this url too.
cofiem
reviewed
Nov 24, 2025
|
|
||
| beforeEach(() => { | ||
| service = new FigshareService(); | ||
| (service as any).baseURL = 'https://api.figshare.test'; |
Contributor
|
A couple of urls to update, then this looks good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in Figshare integration where records with more than 10 data attachments fail due to the default page size on the Figshare API and lacking a pagination implementation in our integration code.