Remove GOPROXY from Dockerfile #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylelemons
reviewed
Dec 26, 2024
Dockerfile
Outdated
| @@ -4,8 +4,6 @@ FROM golang:$GO_BASE_VERSION as builder | |||
| ARG TARGETOS | |||
| ARG TARGETARCH | |||
|
|
|||
| # TODO remove this line once the repo is public | |||
| ENV GOPROXY "https://goproxy.build.ue1.snooguts.net" | |||
| ENV GOPRIVATE "" | |||
| ENV GONOSUMDB "github.com/*" | |||
There was a problem hiding this comment.
You'll want to remove all of the proxy-related configuration, not just GOPROXY.
There was a problem hiding this comment.
Removed the whole proxy paragraph
|
I also ran into the same problem and removing those lines fixed it. @kylelemons are we ok to merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Remove a leftover line from the Dockerfile which prevents building the image for anyone using the repo outside of Reddit.
I was racking my brains why it isn't building, removing the
go.modcache etc. 😆